aboutsummaryrefslogtreecommitdiffstats
path: root/Library/Homebrew
diff options
context:
space:
mode:
authorBaptiste Fontaine2016-02-21 13:15:12 +0100
committerBaptiste Fontaine2016-02-21 21:21:23 +0100
commitbb37aa28242c040b6402af3a9bcc918b9763c44f (patch)
tree6f609959dec6a34b10c23c78f0b682dbf277e66b /Library/Homebrew
parent6a1a57423b6251ffa082f412d090bd2a1cb7fe95 (diff)
downloadbrew-bb37aa28242c040b6402af3a9bcc918b9763c44f.tar.bz2
go: warn about no-op stage_deps calls
Closes Homebrew/homebrew#49389. Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
Diffstat (limited to 'Library/Homebrew')
-rw-r--r--Library/Homebrew/language/go.rb1
-rw-r--r--Library/Homebrew/test/test_language_go.rb13
2 files changed, 14 insertions, 0 deletions
diff --git a/Library/Homebrew/language/go.rb b/Library/Homebrew/language/go.rb
index c051aacc9..08fa16803 100644
--- a/Library/Homebrew/language/go.rb
+++ b/Library/Homebrew/language/go.rb
@@ -7,6 +7,7 @@ module Language
# The resource names should be the import name of the package,
# e.g. `resource "github.com/foo/bar"`
def self.stage_deps(resources, target)
+ opoo "tried to stage empty resources array" if resources.empty?
resources.grep(Resource::Go) { |resource| resource.stage(target) }
end
end
diff --git a/Library/Homebrew/test/test_language_go.rb b/Library/Homebrew/test/test_language_go.rb
new file mode 100644
index 000000000..0ad7f07fe
--- /dev/null
+++ b/Library/Homebrew/test/test_language_go.rb
@@ -0,0 +1,13 @@
+# -*- coding: UTF-8 -*-
+
+require "testing_env"
+require "language/go"
+
+class LanguageGoTests < Homebrew::TestCase
+ def test_stage_deps_empty
+ Language::Go.expects(:opoo).once
+ mktmpdir do |path|
+ shutup { Language::Go.stage_deps [], path }
+ end
+ end
+end