| Age | Commit message (Collapse) | Author |
|---|
|
audit: Allow skipping/selective running of cops and cops refactor
|
|
|
|
|
|
|
|
Also refactor audit cops into two "departments"
- FormulaAudit
- FormulaAuditStrict
|
|
|
|
|
|
There's been an informal ban for a while but let's
be punchier because this crops up still.
|
|
Make sure that `if build.with?` isn't caught.
|
|
When auditing new formulae without `--new-formula` the
`audit_revision_and_version_scheme` method fails ungracefully. Instead,
set some better defaults so fewer checks are needed.
Fixes #2551.
|
|
This was removed in #2540 but this call site was note updated to use
the `search_taps` method instead.
|
|
audit: audit_components method to rubocops and tests
|
|
Another attempt at fixing `brew audit` issues around detecting
`revision` and `version_scheme` changes correctly. First done in #1754
and #2086 (reverted in #2099 and #2100).
To ease future debugging a `ph` helper has been added to print a hash
and a series of RSpec tests to verify that the `revision`,
`version_scheme` and `version` formula version audits behave as
expected.
Fixes #1731.
|
|
|
|
audit: flip GNU mirror preference.
|
|
Now that both the primary and mirror URLs use HTTPS we can flip these
around so the primary URL is the primary URL and we don't have problems
with waiting for mirror propagation.
|
|
This means that if e.g. the unversioned formulae exists in another tap
this audit won't produce a false positive.
|
|
audit: ensure default dependencies don't use options.
|
|
Option dependencies are nasty as they cause unnecessary builds from
source.
|
|
We may under some circumstances accept these anyway but it's better to
nudge people into the right behaviours on local `audit`s.
|
|
|
|
Add `--only` and `--except` methods which can be used to selectively
enable or disable audit groups.
|
|
audit: check for more universal usage.
|
|
audit: deprecate language module requirements.
|
|
As requested in #11462 by @neutric as this produces confusing,
incorrect output.
|
|
Make `brew audit` complain about language module requirements because
they provide a crappy user experience compared to vendoring and we’re
not really fixing bugs in them any more.
|
|
Also check for `ENV.universal_binary` and `build.universal?`. The prior
is still required for `wine` and the latter should never be required any
longer.
|
|
Port audit_desc audit rules to a cop
|
|
Was missing a formula object being passed.
|
|
audit: check for unversioned formulae.
|
|
Additionally, ignore the cctools formula itself, since it obviously
needs to check cctools invocations.
|
|
audit: Check for invocations of cctools.
|
|
|
|
If we're adding a versioned formulae we want to ensure that there's also
an unversioned one too.
|
|
|
|
|
|
|
|
Hint at new location of migrated formulae
|
|
audit: check system dupe deps on new formulae.
|
|
This will allow extending this class so it can be used by more than
just blacklisting.
|
|
This has known issues with our `ghostscript` formula, we can't test it
on CI and is a ludicrously heavy dependency that in many cases can be
avoided by upstream providing prebuilt documentation.
|
|
Provide a gentle nudge to users to check if these dependencies are
definitely required.
|
|
Previously, the http_content_headers_and_checksum method always
downloaded the entire url, including headers. These downloads
periodically hang, outputting false positives or wreaking havoc on
the CI. Therefore, use curl's --max-time arg to prevent this by
setting a hard limit of 600 seconds when the entire file is going
to be used to detect whether the url can be changed to use the HTTPS
protocol instead of HTTP. Otherwise, if the url already is HTTPS, limit
the download time to 25 seconds since only the headers, not contents, matter.
|
|
|
|
|
|
audit: do not warn about reachability of `brew mirror`ed URL
|
|
|
|
|
|
this is necessary because they install conflicting scripts into
HOMEBREW_PREFIX/etc/profile.d
|
|
Don't check Subversion HTTPS pre-Sierra.
|
