aboutsummaryrefslogtreecommitdiffstats
path: root/Library/Homebrew/dev-cmd/audit.rb
diff options
context:
space:
mode:
authorDominyk Tiller2017-04-28 17:37:46 +0100
committerDominyk Tiller2017-04-28 17:38:01 +0100
commit2ad43cb1fddbc056d5f5d389e4c24cdb26dfd2d8 (patch)
tree751702be5794c8bbdbb87a2baed020876cc8058b /Library/Homebrew/dev-cmd/audit.rb
parent539881f51a69b1f5cf169766d1115c8b7343bd09 (diff)
downloadbrew-2ad43cb1fddbc056d5f5d389e4c24cdb26dfd2d8.tar.bz2
audit: formally ban go get usage
There's been an informal ban for a while but let's be punchier because this crops up still.
Diffstat (limited to 'Library/Homebrew/dev-cmd/audit.rb')
-rw-r--r--Library/Homebrew/dev-cmd/audit.rb4
1 files changed, 4 insertions, 0 deletions
diff --git a/Library/Homebrew/dev-cmd/audit.rb b/Library/Homebrew/dev-cmd/audit.rb
index b69fbcfb7..782405207 100644
--- a/Library/Homebrew/dev-cmd/audit.rb
+++ b/Library/Homebrew/dev-cmd/audit.rb
@@ -885,6 +885,10 @@ class FormulaAuditor
problem "Formulae using virtualenvs do not need a `setuptools` resource."
end
+ if text =~ /system\s+['"]go['"],\s+['"]get['"]/
+ problem "Formulae should not use `go get`. If non-vendored resources are required use `go_resource`s."
+ end
+
return unless text.include?('require "language/go"') && !text.include?("go_resource")
problem "require \"language/go\" is unnecessary unless using `go_resource`s"
end