| Age | Commit message (Collapse) | Author |
|---|
|
and improve wording or formatting where necessary.
|
|
These are both tools that end-users can find useful on occasion so it
doesn't make sense to hide them.
|
|
In 'readall.rb', replaced multi-step 'each' loop with one-line method chain of Ruby enumerator methods
|
|
complexity savings
|
|
|
|
'#{HOMEBREW_LIBRARY_PATH}/**/*.rb'
|
|
|
|
|
|
of Ruby enumerator methods
|
|
|
|
Also update command specifications to match descriptions.
|
|
|
|
|
|
Also, flag those that we never want to be in a manpage.
|
|
- ignore Cask's files in `readall` (for now, there's an intentional
syntax error that will need fixed)
- run Cask's tests if they exist
- don't check Cask's files in coverage reports (for now)
|
|
`any?` is not the opposite of `empty?`. Besides the case that
`[false, nil].any?` will return false, `any?`(O(n)) has much worse
performance than `empty?`(O(1)).
|
|
* readall: move readall logic to new class.
* tap: run readall when tapping.
This will prevent tapping an tap with syntax errors from causing issues
for users.
Fixes #58.
|
|
Closes #119.
Signed-off-by: Martin Afanasjew <martin@afanasjew.de>
|
|
Since switching from `system` to `Utils.popen_read` we no longer need to
suppress Ruby's output of `Syntax OK` to `$stdout`.
|
|
Previously, syntax warnings were printed, but didn't cause `readall` to
exit with a non-zero exit code. Now they do, making it easier to catch
accidentally introduced syntax warnings in the test bot.
|
|
Also make `Homebrew/homebrew` as an alias of this tap to keep
backward compatibility.
|
|
Core tap will be separated from core code in the near future.
It makes sense to rename it to CoreTap.
|
|
For users whose local brew is at around 2015-06-11 to 2015-08-06,
running `brew update` will emit following error:
Error: uninitialized constant Formulary::CoreFormulaRepository
This is caused by the same bug described in Homebrew/homebrew#42553.
This commit workarounds this issue and restores `brew update` compatibility
for users mentioned above.
Also cleanup legacy `require "cmd/tap"`.
|
|
Let's hide implementation detail on where to find alias directory.
This will benefit future core code and formulae separation.
Also let `brew readall` check aliases for all taps.
|
|
|
|
It's now handled by Tap.fetch
|
|
There are plenty of IO operations inside Tap object, and it will be more
when implementing formula alias reverse look up(e.g. list all of alias
names for a formula). So let's cache them.
Some benchmark:
$ time brew info $(brew ruby -e 'puts Formula.tap_names') > /dev/null
Before: 6.40s user 2.42s system 96% cpu 9.134 total
After: 4.75s user 0.77s system 97% cpu 5.637 total
Closes Homebrew/homebrew#44377.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
The previous code would fail to reset stdout after thread jobs are finshed.
|
|
|
|
|
|
Before
```
$ time brew readall
brew readall 10.63s user 0.36s system 99% cpu 11.003 total
```
After
```
$ time brew readall
brew readall 5.62s user 0.24s system 99% cpu 5.859 total
```
Closes Homebrew/homebrew#42302.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
|
|
|
|
|
|
|
|
This is a little code refactoring splited from Homebrew/homebrew#36753
The idea is to eliminate `Formula#path` outside of `formulary.rb`.
And I indent to deprecate `Formula#path` method when I reimplement
symlink free tap function.
Closes Homebrew/homebrew#39313.
|
|
Otherwise e.g. --debug will be interpreted as a (bad) tap argument.
Closes Homebrew/homebrew#38569.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
The Ruby 1.8 implementation seems to be really flaky, unfortunately.
|
|
|
|
These have all been moved to Formulary.
|
|
|
|
|
