| Age | Commit message (Collapse) | Author |
|---|
|
We attempted to find the help message for commands before loading custom
commands in the path.
|
|
Don’t rely on having external commands always present in the PATH in
order to find them. Instead, provide an accessory method to Tap so
they can be added and used when needed.
While we’re here, do some general refactoring and cleanup of the
command code in these places.
|
|
Avoid adding all the tap commands to the PATH when not necessary.
|
|
Fixes querying Cask commands' help
|
|
|
|
|
|
|
|
|
|
(and also delete the extra help_flag case, it's no longer needed)
|
|
|
|
|
|
I meant to verify that both a cmd and a help flag were received from the
shell
|
|
- If a non-existent command with a flag is queried to Cask, the latter
is printed instead of the command
- If the help from a not-yet-tapped cask's command is queried, it
prints brew tap's help infinitely
Fixes caskroom/homebrew-cask#28977
|
|
|
|
- `brew.rb` needed updated to fail unless on Ruby 2.3
- `brew update` should unset `HOMEBREW_RUBY_PATH` to ensure that this
doesn't "stick" on a Ruby 2.0 version after a portable Ruby has been
installed.
|
|
|
|
The `brew test` tests were failing as they were unable to include
`test/unit/assertions`. This is because it's a gem and we were setting
the `GEM_HOME` so system gems were being ignored.
While I was there and examining the `$LOAD_PATH`: reduce the number of
things we add there by using `Bundler.with_clean_env` and only adding
`HOMEBREW_LIBRARY_PATH` in the `$LOAD_PATH` if it isn't already there
(which it always is [and has to be] for integration tests).
This also seems to have the side effect of speeding up integration
tests from 1m26s to 1m8s on my machine.
|
|
|
|
|
|
analytics: remove unused analytics.
|
|
Otherwise: you may be on an old enough version that we don't care.
|
|
We didn't end up using the `screenview` and `exception` analytics as
much as expected so let's remove them and focus on stuff that's
formula-specific.
|
|
brew.rb: use HOMEBREW_PATH for external commands.
|
|
They shouldn’t need to handle our environment filtering on the PATH as
we’re essentially breaking an API for them otherwise.
|
|
|
|
|
|
|
|
|
|
|
|
This reverts commit 3e4547f52e7ebec633f8bfefc8a396d944edf908, reversing
changes made to 6edf9382bcc1240ad6f97c8b752cfe56cef9965d.
|
|
This reverts commit 2372872974d1049c2beafe7dedb7f8f882502058, reversing
changes made to 3e4547f52e7ebec633f8bfefc8a396d944edf908.
|
|
If people have `HOMEBREW_RUBY_PATH` set then things explode in a rather
confusing fashion. Instead, run `bundle` for them with the arguments
that they'd want.
Also, move `macho` requires into the module itself; it's a pain having
to do everything for Bundler before requiring `pathname` which is a core
Ruby class.
|
|
Homebrew's actually ended up using a fair few gems. While we want to
avoid Bundler at runtime (and this PR still does that, in fact uses
Bundler even less at runtime than it did before) writing our own version
to use at build-time seems redundant.
|
|
|
|
|
|
Fix those that can be done so without tearing Homebrew to pieces and
remove the comments for those that can never be done.
|
|
|
|
Rather than Homebrew/brew or Homebrew/homebrew-core.
|
|
It's not necessary to make this a hard failure so don't (and this makes
it more consistent with `brew.sh`).
Fixes #1462.
|
|
|
|
brew.sh: don't autoupdate if --help passed
|
|
help: support `#:` help in external commands.
|
|
|
|
|
|
|
|
Fixes https://github.com/Homebrew/homebrew-test-bot/issues/3
|
|
|
|
For tagged commits produces the output:
- `1.0.1`
For untagged commits with a dirty tree produces the output:
- `1.0.1-19-g23efbc5-dirty`
Performance:
```
git describe --tags --dirty 2> /dev/null
0.07s user 0.01s system 96% cpu 0.086 total
```
This means we can tag any commit without needing to manually remember
to bump the revision every time.
|
|
|
|
Move the `LinkedKegs` migration into `utils.rb` so it can also be called
from `brew.rb` on startup.
|
