diff options
Diffstat (limited to 'Library')
| -rw-r--r-- | Library/Homebrew/dev-cmd/audit.rb | 5 | ||||
| -rw-r--r-- | Library/Homebrew/test/audit_test.rb | 11 |
2 files changed, 16 insertions, 0 deletions
diff --git a/Library/Homebrew/dev-cmd/audit.rb b/Library/Homebrew/dev-cmd/audit.rb index 35d590b69..a8c18f7b6 100644 --- a/Library/Homebrew/dev-cmd/audit.rb +++ b/Library/Homebrew/dev-cmd/audit.rb @@ -605,6 +605,11 @@ class FormulaAuditor def audit_homepage homepage = formula.homepage + if homepage.nil? || homepage.empty? + problem "Formula should have a homepage." + return + end + unless homepage =~ %r{^https?://} problem "The homepage should start with http or https (URL is #{homepage})." end diff --git a/Library/Homebrew/test/audit_test.rb b/Library/Homebrew/test/audit_test.rb index f4b7cae4a..66e5af567 100644 --- a/Library/Homebrew/test/audit_test.rb +++ b/Library/Homebrew/test/audit_test.rb @@ -466,6 +466,17 @@ class FormulaAuditorTests < Homebrew::TestCase end end + def test_audit_without_homepage + fa = formula_auditor "foo", <<-EOS.undent, online: true + class Foo < Formula + url "http://example.com/foo-1.0.tgz" + end + EOS + + fa.audit_homepage + assert_match "Formula should have a homepage.", fa.problems.first + end + def test_audit_xcodebuild_suggests_symroot fa = formula_auditor "foo", <<-EOS.undent class Foo < Formula |