aboutsummaryrefslogtreecommitdiffstats
path: root/Library
diff options
context:
space:
mode:
Diffstat (limited to 'Library')
-rw-r--r--Library/Homebrew/rubocops/lines_cop.rb12
-rw-r--r--Library/Homebrew/test/rubocops/lines_cop_spec.rb24
2 files changed, 30 insertions, 6 deletions
diff --git a/Library/Homebrew/rubocops/lines_cop.rb b/Library/Homebrew/rubocops/lines_cop.rb
index b6567466a..dac523424 100644
--- a/Library/Homebrew/rubocops/lines_cop.rb
+++ b/Library/Homebrew/rubocops/lines_cop.rb
@@ -314,12 +314,12 @@ module RuboCop
next unless match = regex_match_group(arg, %r{with(out)?-(.*)})
problem "Use build.with#{match[1]}? \"#{match[2]}\" instead of build.include? 'with#{match[1]}-#{match[2]}'"
end
- #
- # find_instance_method_call(body_node, :build, :include?) do |m|
- # arg = parameters(m).first
- # next unless match = regex_match_group(arg, %r{\-\-(.*)})
- # problem "Reference '#{match[1]}' without dashes"
- # end
+
+ find_instance_method_call(body_node, :build, :include?) do |m|
+ arg = parameters(m).first
+ next unless match = regex_match_group(arg, %r{\-\-(.*)})
+ problem "Reference '#{match[1]}' without dashes"
+ end
end
diff --git a/Library/Homebrew/test/rubocops/lines_cop_spec.rb b/Library/Homebrew/test/rubocops/lines_cop_spec.rb
index 36c6272b3..288ca8f8f 100644
--- a/Library/Homebrew/test/rubocops/lines_cop_spec.rb
+++ b/Library/Homebrew/test/rubocops/lines_cop_spec.rb
@@ -787,6 +787,30 @@ describe RuboCop::Cop::FormulaAudit::Miscellaneous do
expect_offense(expected, actual)
end
end
+
+ it "with build.include? with dashed args" do
+ source = <<-EOS.undent
+ class Foo < Formula
+ desc "foo"
+ url 'http://example.com/foo-1.0.tgz'
+ def post_install
+ return if build.include? "--bar"
+ end
+ end
+ EOS
+
+ expected_offenses = [{ message: "Reference 'bar' without dashes",
+ severity: :convention,
+ line: 5,
+ column: 30,
+ source: source }]
+
+ inspect_source(cop, source)
+
+ expected_offenses.zip(cop.offenses).each do |expected, actual|
+ expect_offense(expected, actual)
+ end
+ end
end
def expect_offense(expected, actual)
expect(actual.message).to eq(expected[:message])