aboutsummaryrefslogtreecommitdiffstats
path: root/Library
diff options
context:
space:
mode:
Diffstat (limited to 'Library')
-rw-r--r--Library/Homebrew/cmd/audit.rb8
1 files changed, 6 insertions, 2 deletions
diff --git a/Library/Homebrew/cmd/audit.rb b/Library/Homebrew/cmd/audit.rb
index edeb03d03..3a8aa876f 100644
--- a/Library/Homebrew/cmd/audit.rb
+++ b/Library/Homebrew/cmd/audit.rb
@@ -296,8 +296,12 @@ class FormulaAuditor
problem "use \"scons *args\" instead of \"system 'scons', *args\""
end
- if text =~ /system\s+['"]xcodebuild/ && text !~ /SYMROOT=/
- problem "xcodebuild should be passed an explicit \"SYMROOT\""
+ if text =~ /system\s+['"]xcodebuild/
+ problem %{use "xcodebuild *args" instead of "system 'xcodebuild', *args"}
+ end
+
+ if text =~ /xcodebuild[ (]["'*]/ && text !~ /SYMROOT=/
+ problem %{xcodebuild should be passed an explicit "SYMROOT"}
end
if text =~ /Formula\.factory\(/