aboutsummaryrefslogtreecommitdiffstats
path: root/Library
diff options
context:
space:
mode:
Diffstat (limited to 'Library')
-rw-r--r--Library/Homebrew/test/dev-cmd/audit_spec.rb68
1 files changed, 68 insertions, 0 deletions
diff --git a/Library/Homebrew/test/dev-cmd/audit_spec.rb b/Library/Homebrew/test/dev-cmd/audit_spec.rb
index 8dd3aee72..857b69c07 100644
--- a/Library/Homebrew/test/dev-cmd/audit_spec.rb
+++ b/Library/Homebrew/test/dev-cmd/audit_spec.rb
@@ -217,6 +217,74 @@ describe FormulaAuditor do
end
end
+ describe "#audit_deps" do
+ describe "a dependency on a macOS-provided keg-only formula" do
+ describe "which is whitelisted" do
+ let(:fa) do
+ formula_auditor "foo", <<-EOS.undent, new_formula: true
+ class Foo < Formula
+ url "http://example.com/foo-1.0.tgz"
+ homepage "http://example.com"
+
+ depends_on "openssl"
+ end
+ EOS
+ end
+
+ let(:f_openssl) do
+ formula do
+ url "http://example.com/openssl-1.0.tgz"
+ homepage "http://example.com"
+
+ keg_only :provided_by_macos
+ end
+ end
+
+ before do
+ allow(fa.formula.deps.first)
+ .to receive(:to_formula).and_return(f_openssl)
+ fa.audit_deps
+ end
+
+ subject { fa }
+
+ its(:problems) { are_expected.to be_empty }
+ end
+
+ describe "which is not whitelisted" do
+ let(:fa) do
+ formula_auditor "foo", <<-EOS.undent, new_formula: true
+ class Foo < Formula
+ url "http://example.com/foo-1.0.tgz"
+ homepage "http://example.com"
+
+ depends_on "bc"
+ end
+ EOS
+ end
+
+ let(:f_bc) do
+ formula do
+ url "http://example.com/bc-1.0.tgz"
+ homepage "http://example.com"
+
+ keg_only :provided_by_macos
+ end
+ end
+
+ before do
+ allow(fa.formula.deps.first)
+ .to receive(:to_formula).and_return(f_bc)
+ fa.audit_deps
+ end
+
+ subject { fa }
+
+ its(:problems) { are_expected.to match([/unnecessary/]) }
+ end
+ end
+ end
+
describe "#audit_keg_only_style" do
specify "keg_only_needs_downcasing" do
fa = formula_auditor "foo", <<~EOS, strict: true