aboutsummaryrefslogtreecommitdiffstats
path: root/Library
diff options
context:
space:
mode:
Diffstat (limited to 'Library')
-rw-r--r--Library/Homebrew/cmd/uninstall.rb4
-rw-r--r--Library/Homebrew/keg.rb2
-rw-r--r--Library/Homebrew/test/keg_test.rb13
3 files changed, 16 insertions, 3 deletions
diff --git a/Library/Homebrew/cmd/uninstall.rb b/Library/Homebrew/cmd/uninstall.rb
index c08b13dad..5d02ebd1e 100644
--- a/Library/Homebrew/cmd/uninstall.rb
+++ b/Library/Homebrew/cmd/uninstall.rb
@@ -102,8 +102,8 @@ module Homebrew
attr_reader :reqs, :deps
def initialize(requireds, dependents)
- @reqs = requireds.compact
- @deps = dependents.compact
+ @reqs = requireds
+ @deps = dependents
end
protected
diff --git a/Library/Homebrew/keg.rb b/Library/Homebrew/keg.rb
index bdb618ba2..48014e384 100644
--- a/Library/Homebrew/keg.rb
+++ b/Library/Homebrew/keg.rb
@@ -136,7 +136,7 @@ class Keg
next unless f_kegs
f_kegs.sort_by(&:version).last
- end
+ end.compact
next unless required_kegs.any?
diff --git a/Library/Homebrew/test/keg_test.rb b/Library/Homebrew/test/keg_test.rb
index 14cdc4304..eeead64a0 100644
--- a/Library/Homebrew/test/keg_test.rb
+++ b/Library/Homebrew/test/keg_test.rb
@@ -369,6 +369,19 @@ class InstalledDependantsTests < LinkTestCase
assert_equal [[@keg], ["bar 1.0"]], Keg.find_some_installed_dependents([@keg])
end
+ def test_a_dependency_with_no_tap_in_tab
+ @tap_dep = setup_test_keg("baz", "1.0")
+
+ alter_tab(@keg) { |t| t.source["tap"] = nil }
+
+ dependencies nil
+ Formula["bar"].class.depends_on "foo"
+ Formula["bar"].class.depends_on "baz"
+
+ result = Keg.find_some_installed_dependents([@keg, @tap_dep])
+ assert_equal [[@tap_dep], ["bar"]], result
+ end
+
def test_no_dependencies_anywhere
dependencies nil
assert_empty @keg.installed_dependents