aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--Library/Homebrew/cask/lib/hbc/cli/search.rb1
-rw-r--r--Library/Homebrew/utils/github.rb6
2 files changed, 2 insertions, 5 deletions
diff --git a/Library/Homebrew/cask/lib/hbc/cli/search.rb b/Library/Homebrew/cask/lib/hbc/cli/search.rb
index b299f03ce..e89dced92 100644
--- a/Library/Homebrew/cask/lib/hbc/cli/search.rb
+++ b/Library/Homebrew/cask/lib/hbc/cli/search.rb
@@ -15,7 +15,6 @@ module Hbc
end
def self.search_remote(query)
- return [] if ENV["HOMEBREW_NO_GITHUB_API"]
matches = GitHub.search_code(user: "caskroom", path: "Casks",
filename: query, extension: "rb")
matches.map do |match|
diff --git a/Library/Homebrew/utils/github.rb b/Library/Homebrew/utils/github.rb
index 578d967a4..a1cf5fbba 100644
--- a/Library/Homebrew/utils/github.rb
+++ b/Library/Homebrew/utils/github.rb
@@ -133,7 +133,7 @@ module GitHub
def open(url, data: nil, scopes: [].freeze)
# This is a no-op if the user is opting out of using the GitHub API.
- return if ENV["HOMEBREW_NO_GITHUB_API"]
+ return block_given? ? yield({}) : {} if ENV["HOMEBREW_NO_GITHUB_API"]
args = %W[--header application/vnd.github.v3+json --write-out \n%{http_code}]
args += curl_args
@@ -245,8 +245,6 @@ module GitHub
end
def print_pull_requests_matching(query)
- return [] if ENV["HOMEBREW_NO_GITHUB_API"]
-
open_or_closed_prs = search_issues(query, type: "pr")
open_prs = open_or_closed_prs.select { |i| i["state"] == "open" }
@@ -283,6 +281,6 @@ module GitHub
def search(entity, *queries, **qualifiers)
uri = url_to "search", entity
uri.query = query_string(*queries, **qualifiers)
- open(uri) { |json| Array(json["items"]) }
+ open(uri) { |json| json.fetch("items", []) }
end
end