aboutsummaryrefslogtreecommitdiffstats
path: root/docs
diff options
context:
space:
mode:
authorMike McQuaid2016-10-13 09:09:40 +0100
committerGitHub2016-10-13 09:09:40 +0100
commit8e3fa21967219bce2eb20846433a4774b828e4ff (patch)
tree4381eac5aa72e511fbb4f8f1ac385e215518218c /docs
parent114beb77cd32cd4431a5d213d328b985e348e55e (diff)
downloadbrew-8e3fa21967219bce2eb20846433a4774b828e4ff.tar.bz2
Update based on feedback.
Diffstat (limited to 'docs')
-rw-r--r--docs/New-Maintainer-Checklist.md12
1 files changed, 7 insertions, 5 deletions
diff --git a/docs/New-Maintainer-Checklist.md b/docs/New-Maintainer-Checklist.md
index c2812adab..8745f9b91 100644
--- a/docs/New-Maintainer-Checklist.md
+++ b/docs/New-Maintainer-Checklist.md
@@ -18,10 +18,12 @@ A few requests:
non-trivial (e.g. not a test or audit improvement or version bump) changes
to formulae code and don't merge them unless you get at least one approval
and passing tests.
-- use `brew pull` for formulae changes that require new bottles and let it
- auto-close issues wherever possible (it may take ~5m). When this isn't necessary
- use GitHub's "Merge pull request" button. If in doubt, check with GitX that you've not
- accidentally added merge commits
+- use `brew pull` for formulae changes that require new bottles or change
+ multiple formulae and let it auto-close issues wherever possible (it may
+ take ~5m). When this isn't necessary use GitHub's "Merge pull request"
+ button in "create a merge commit" mode for Homebrew/brew or "squash and
+ merge" for a single formulae change. If in doubt, check with e.g. GitX that
+ you've not accidentally added merge commits
- still create your branches on your fork rather than in the main repository
- if still in doubt please ask for help and we'll help you out - these are
probably worth a read:
@@ -37,7 +39,7 @@ Thanks for all your work so far!
If they accept, follow a few steps to get them set up:
- [x] Invite them to the [**@Homebrew/maintainers** team](https://github.com/orgs/Homebrew/teams/maintainers) to give them write access to all repositories (but don't make them owners yet). They will need to enable [GitHub's Two Factor Authentication](https://help.github.com/articles/about-two-factor-authentication/).
-- [x] Ask them to sign in to [Bintray](https://bintray.com) using them GitHub account and they should auto-sync to [Bintray's Homebrew organisation](https://bintray.com/homebrew/organization/edit/members) as a member so they can publish new bottles
+- [x] Ask them to sign in to [Bintray](https://bintray.com) using their GitHub account and they should auto-sync to [Bintray's Homebrew organisation](https://bintray.com/homebrew/organization/edit/members) as a member so they can publish new bottles
- [x] Add them to the [Jenkins' GitHub Authorization Settings admin user names](https://bot.brew.sh/configureSecurity/) so they can adjust settings and restart jobs
- [x] Add them to the [Jenkins' GitHub Pull Request Builder admin list](https://bot.brew.sh/configure) to enable `@BrewTestBot test this please` for them
- [x] Invite them to the [`homebrew-dev` private maintainers mailing list](https://groups.google.com/forum/#!managemembers/homebrew-dev/invite)