lines_cop: deprecate 'needs :openmp'.

2 files changed, 15 insertions, 0 deletions

diff --git a/Library/Homebrew/rubocops/lines_cop.rb b/Library/Homebrew/rubocops/lines_cop.rb
index fdeb165ed..4e7aa1adb 100644
--- a/Library/Homebrew/rubocops/lines_cop.rb
+++ b/Library/Homebrew/rubocops/lines_cop.rb
@@ -276,6 +276,10 @@ module RuboCop
             problem "'fails_with :llvm' is now a no-op so should be removed"
           end
 
+          find_method_with_args(body_node, :needs, :openmp) do
+            problem "'needs :openmp' should be replaced with 'depends_on \"gcc\"'"
+          end
+
           find_method_with_args(body_node, :system, /^(otool|install_name_tool|lipo)/) do
             next if @formula_name == "cctools"
             problem "Use ruby-macho instead of calling #{@offensive_node.source}"
diff --git a/Library/Homebrew/test/rubocops/lines_cop_spec.rb b/Library/Homebrew/test/rubocops/lines_cop_spec.rb
index ee1de059c..19492c252 100644
--- a/Library/Homebrew/test/rubocops/lines_cop_spec.rb
+++ b/Library/Homebrew/test/rubocops/lines_cop_spec.rb
@@ -731,6 +731,17 @@ describe RuboCop::Cop::FormulaAudit::Miscellaneous do
       RUBY
     end
 
+    it "deprecated needs :openmp usage" do
+      expect_offense(<<~RUBY)
+        class Foo < Formula
+          desc "foo"
+          url 'http://example.com/foo-1.0.tgz'
+          needs :openmp
+          ^^^^^^^^^^^^^ 'needs :openmp' should be replaced with 'depends_on \"gcc\"'
+        end
+      RUBY
+    end
+
     it "deprecated MACOS_VERSION const usage" do
       expect_offense(<<~RUBY)
         class Foo < Formula