aboutsummaryrefslogtreecommitdiffstats
path: root/Library
diff options
context:
space:
mode:
authorMike McQuaid2016-11-02 15:57:19 -0400
committerMike McQuaid2016-11-02 15:57:19 -0400
commitf35a86ff70fbc89d03811c821689c7e6c0536899 (patch)
treeff114fd1ae134c112d159d30695dfbc9e67473cf /Library
parent7aa26f781707d1836f6dcd9fb82ee70d32e23dcd (diff)
downloadbrew-f35a86ff70fbc89d03811c821689c7e6c0536899.tar.bz2
audit: stricter test system calls check.
Ensure that the name is suffixed with whitespace or quotes.
Diffstat (limited to 'Library')
-rw-r--r--Library/Homebrew/dev-cmd/audit.rb2
1 files changed, 1 insertions, 1 deletions
diff --git a/Library/Homebrew/dev-cmd/audit.rb b/Library/Homebrew/dev-cmd/audit.rb
index 32ff14de1..df068c99f 100644
--- a/Library/Homebrew/dev-cmd/audit.rb
+++ b/Library/Homebrew/dev-cmd/audit.rb
@@ -735,7 +735,7 @@ class FormulaAuditor
end
bin_names.each do |name|
["system", "shell_output", "pipe_output"].each do |cmd|
- if text =~ /(def test|test do).*#{cmd}[\(\s]+['"]#{name}/m
+ if text =~ /(def test|test do).*#{cmd}[\(\s]+['"]#{name}[\s'"]/m
problem %(fully scope test #{cmd} calls e.g. #{cmd} "\#{bin}/#{name}")
end
end