aboutsummaryrefslogtreecommitdiffstats
path: root/Library
diff options
context:
space:
mode:
authorJack Nagel2014-08-09 10:30:43 -0500
committerJack Nagel2014-08-09 10:30:43 -0500
commitf0b75b286957f7ba012461492f1635a13a5dbe16 (patch)
tree8e5b4e0e3e7c3445e17eabc9e8fec400b51d64d8 /Library
parent618bb9b41356bcab84c13905cf013b02cf8d3966 (diff)
downloadbrew-f0b75b286957f7ba012461492f1635a13a5dbe16.tar.bz2
Stop duping options when duping the build object
The options collection cannot be mutated from the build object, so it can be shared among copies safely.
Diffstat (limited to 'Library')
-rw-r--r--Library/Homebrew/build_options.rb2
-rw-r--r--Library/Homebrew/test/test_build_options.rb6
2 files changed, 0 insertions, 8 deletions
diff --git a/Library/Homebrew/build_options.rb b/Library/Homebrew/build_options.rb
index 28fbb959c..b04c9dc1d 100644
--- a/Library/Homebrew/build_options.rb
+++ b/Library/Homebrew/build_options.rb
@@ -7,7 +7,6 @@ class BuildOptions
attr_accessor :args
attr_accessor :universal
- attr_reader :options
def initialize(args, options)
@args = Options.coerce(args)
@@ -16,7 +15,6 @@ class BuildOptions
def initialize_copy(other)
super
- @options = other.options.dup
@args = other.args.dup
end
diff --git a/Library/Homebrew/test/test_build_options.rb b/Library/Homebrew/test/test_build_options.rb
index 11b3145ba..4fa332230 100644
--- a/Library/Homebrew/test/test_build_options.rb
+++ b/Library/Homebrew/test/test_build_options.rb
@@ -37,12 +37,6 @@ class BuildOptionsTests < Homebrew::TestCase
assert_includes @build.unused_options, "--without-baz"
end
- def test_copies_do_not_share_underlying_options
- orig = BuildOptions.new [], Options.new
- copy = orig.dup
- refute_same orig.options, copy.options
- end
-
def test_copies_do_not_share_underlying_args
orig = BuildOptions.new [], Options.new
copy = orig.dup