aboutsummaryrefslogtreecommitdiffstats
path: root/Library
diff options
context:
space:
mode:
authorJonathan Hitchcock2012-03-06 17:03:39 +0200
committerMax Howell2012-03-06 15:38:33 +0000
commitde30a7844f6bf08c040ec81500e9d6d73409e3d6 (patch)
treeec1c887f2b2d7130985bda4791cde08f30fa332d /Library
parentcc78050dc5607ac827429fe27686f71a7e77716c (diff)
downloadbrew-de30a7844f6bf08c040ec81500e9d6d73409e3d6.tar.bz2
'brew doctor' provides bad example command
If there are multiple dependencies missing, 'brew doctor' can suggest that you run something like: brew install autoconf libyaml autoconf, libyaml This commit improves that output. Closes Homebrew/homebrew#10720. Signed-off-by: Max Howell <max@methylblue.com>
Diffstat (limited to 'Library')
-rwxr-xr-xLibrary/Contributions/examples/brew-missing.rb2
-rw-r--r--Library/Homebrew/cmd/doctor.rb4
2 files changed, 4 insertions, 2 deletions
diff --git a/Library/Contributions/examples/brew-missing.rb b/Library/Contributions/examples/brew-missing.rb
index b3f287541..50fae12e4 100755
--- a/Library/Contributions/examples/brew-missing.rb
+++ b/Library/Contributions/examples/brew-missing.rb
@@ -29,7 +29,7 @@ def main
unless missing_deps.empty?
print "#{f.name}: " if formulae_to_check.size > 1
- puts "#{missing_deps * ', '}"
+ puts "#{missing_deps * ' '}"
end
end
end
diff --git a/Library/Homebrew/cmd/doctor.rb b/Library/Homebrew/cmd/doctor.rb
index d87b86ec6..ad24bb958 100644
--- a/Library/Homebrew/cmd/doctor.rb
+++ b/Library/Homebrew/cmd/doctor.rb
@@ -718,7 +718,9 @@ def check_missing_deps
s = []
`brew missing`.each_line do |line|
line =~ /(.*): (.*)/
- s << $2 unless s.include? $2
+ $2.split.each do |dep|
+ s << dep unless s.include? dep
+ end
end
if s.length > 0 then <<-EOS.undent
Some installed formula are missing dependencies.