aboutsummaryrefslogtreecommitdiffstats
path: root/Library
diff options
context:
space:
mode:
authorZhiming Wang2016-10-25 01:44:40 -0400
committerZhiming Wang2016-10-25 01:44:40 -0400
commitdd527bfcdc9c36215f406a347cb179dc90fd7fe2 (patch)
tree996cf8e517f34cce9c1504984dffcb93b4d47d9c /Library
parent79e8cdd3ed8c7f5dee573648d55eb3d3e305de19 (diff)
downloadbrew-dd527bfcdc9c36215f406a347cb179dc90fd7fe2.tar.bz2
bottle: fix nonexistent pyc bug
We were deleting pyc files *after* replace_locations_with_placeholders and recording changed_files, meaning that some of the recorded files were to be deleted. The correct order is the opposite. A sample failed session: https://bot.brew.sh/job/Homebrew%20Core/10080/version=el_capitan/testReport/junit/brew-test-bot/el_capitan/bottle_buku/.
Diffstat (limited to 'Library')
-rw-r--r--Library/Homebrew/dev-cmd/bottle.rb4
1 files changed, 2 insertions, 2 deletions
diff --git a/Library/Homebrew/dev-cmd/bottle.rb b/Library/Homebrew/dev-cmd/bottle.rb
index dcc9e0e98..b1a3ebb43 100644
--- a/Library/Homebrew/dev-cmd/bottle.rb
+++ b/Library/Homebrew/dev-cmd/bottle.rb
@@ -190,12 +190,12 @@ module Homebrew
changed_files = nil
begin
+ keg.delete_pyc_files!
+
unless ARGV.include? "--skip-relocation"
changed_files = keg.replace_locations_with_placeholders
end
- keg.delete_pyc_files!
-
Tab.clear_cache
tab = Tab.for_keg(keg)
original_tab = tab.dup