Merge pull request #2262 from MikeMcQuaid/subversion-https-audit

Don't check Subversion HTTPS pre-Sierra.

3 files changed, 13 insertions, 3 deletions

diff --git a/Library/Homebrew/dev-cmd/audit.rb b/Library/Homebrew/dev-cmd/audit.rb
index 3a4e39578..d18e3b821 100644
--- a/Library/Homebrew/dev-cmd/audit.rb
+++ b/Library/Homebrew/dev-cmd/audit.rb
@@ -679,8 +679,6 @@ class FormulaAuditor
 
     return unless @online
 
-    # The system Curl is too old and unreliable with HTTPS homepages on
-    # Yosemite and below.
     return unless DevelopmentTools.curl_handles_most_https_homepages?
     if http_content_problem = FormulaAuditor.check_http_content(homepage,
                                              user_agents: [:browser, :default])
@@ -1573,6 +1571,7 @@ class ResourceAuditor
           problem "The URL #{url} is not a valid git URL"
         end
       elsif strategy <= SubversionDownloadStrategy
+        next unless DevelopmentTools.subversion_handles_most_https_certificates?
         unless Utils.svn_remote_exists url
           problem "The URL #{url} is not a valid svn URL"
         end
diff --git a/Library/Homebrew/development_tools.rb b/Library/Homebrew/development_tools.rb
index 625d5ea86..8f417b082 100644
--- a/Library/Homebrew/development_tools.rb
+++ b/Library/Homebrew/development_tools.rb
@@ -117,6 +117,10 @@ class DevelopmentTools
     def curl_handles_most_https_homepages?
       true
     end
+
+    def subversion_handles_most_https_certificates?
+      true
+    end
   end
 end
 
diff --git a/Library/Homebrew/extend/os/mac/development_tools.rb b/Library/Homebrew/extend/os/mac/development_tools.rb
index 1bb12a3d1..f54c6b8a3 100644
--- a/Library/Homebrew/extend/os/mac/development_tools.rb
+++ b/Library/Homebrew/extend/os/mac/development_tools.rb
@@ -78,8 +78,15 @@ class DevelopmentTools
     end
 
     def curl_handles_most_https_homepages?
-      # The system Curl is too old for some modern HTTPS homepages on Yosemite.
+      # The system Curl is too old for some modern HTTPS homepages on
+      # older macOS versions.
       MacOS.version >= :el_capitan
     end
+
+    def subversion_handles_most_https_certificates?
+      # The system Subversion is too old for some HTTPS certificates on
+      # older macOS versions.
+      MacOS.version >= :sierra
+    end
   end
 end