aboutsummaryrefslogtreecommitdiffstats
path: root/Library
diff options
context:
space:
mode:
authorMarkus Reiter2017-05-29 17:50:13 +0200
committerMarkus Reiter2017-05-29 17:50:13 +0200
commitd700a5ba188b0a01fba21401c4432239c29835bc (patch)
tree9be4441f5331743b3979f0310f2a3dc05f0e0906 /Library
parent481a91a92d869c7363edcc7c114b972680ba1aaa (diff)
downloadbrew-d700a5ba188b0a01fba21401c4432239c29835bc.tar.bz2
Use `Formatter::pluralize` where possible.
Diffstat (limited to 'Library')
-rw-r--r--Library/Homebrew/cask/lib/hbc/cli/doctor.rb3
-rw-r--r--Library/Homebrew/cmd/uninstall.rb6
-rw-r--r--Library/Homebrew/utils/formatter.rb10
3 files changed, 9 insertions, 10 deletions
diff --git a/Library/Homebrew/cask/lib/hbc/cli/doctor.rb b/Library/Homebrew/cask/lib/hbc/cli/doctor.rb
index 64cd11f9e..fe7889b73 100644
--- a/Library/Homebrew/cask/lib/hbc/cli/doctor.rb
+++ b/Library/Homebrew/cask/lib/hbc/cli/doctor.rb
@@ -55,8 +55,7 @@ module Hbc
end
def self.cask_count_for_tap(tap)
- count = tap.cask_files.count
- "#{count} #{count == 1 ? "cask" : "casks"}"
+ Formatter.pluralize(tap.cask_files.count, "cask")
rescue StandardError
"0 #{error_string "error reading #{tap.path}"}"
end
diff --git a/Library/Homebrew/cmd/uninstall.rb b/Library/Homebrew/cmd/uninstall.rb
index 9c51a0d1c..4839ba1e0 100644
--- a/Library/Homebrew/cmd/uninstall.rb
+++ b/Library/Homebrew/cmd/uninstall.rb
@@ -55,7 +55,7 @@ module Homebrew
if rack.directory?
versions = rack.subdirs.map(&:basename)
- verb = versions.length == 1 ? "is" : "are"
+ verb = Formatter.pluralize(versions.length, "is", "are")
puts "#{keg.name} #{versions.join(", ")} #{verb} still installed."
puts "Remove all versions with `brew uninstall --force #{keg.name}`."
end
@@ -109,11 +109,11 @@ module Homebrew
protected
def are(items)
- items.count == 1 ? "is" : "are"
+ Formatter.pluralize(items.count, "is", "are", show_count: false)
end
def they(items)
- items.count == 1 ? "it" : "they"
+ Formatter.pluralize(items.count, "it", "they", show_count: false)
end
def list(items)
diff --git a/Library/Homebrew/utils/formatter.rb b/Library/Homebrew/utils/formatter.rb
index 099b1c6d3..a29b43c8d 100644
--- a/Library/Homebrew/utils/formatter.rb
+++ b/Library/Homebrew/utils/formatter.rb
@@ -91,17 +91,17 @@ module Formatter
output
end
- def pluralize(count, singular, plural = nil)
- return "#{count} #{singular}" if count == 1
+ def pluralize(count, singular, plural = nil, show_count: true)
+ return (show_count ? "#{count} #{singular}" : singular.to_s) if count == 1
- *adjectives, noun = singular.split(" ")
+ *adjectives, noun = singular.to_s.split(" ")
plural ||= {
"formula" => "formulae",
}.fetch(noun, "#{noun}s")
- words = adjectives << plural
+ words = adjectives.push(plural).join(" ")
- "#{count} #{words.join(" ")}"
+ show_count ? "#{count} #{words}" : words
end
end