aboutsummaryrefslogtreecommitdiffstats
path: root/Library
diff options
context:
space:
mode:
authorMisty De Meo2012-04-09 13:09:41 -0500
committerMisty De Meo2012-04-09 13:19:42 -0500
commitc134ba6c4a4c224ab6f294bcc484f1fd1cbab0aa (patch)
treebef754897bdf2a4bf359120f27025c025e157383 /Library
parent90400eceb1d989de4a55c22e721aefae3fee21bf (diff)
downloadbrew-c134ba6c4a4c224ab6f294bcc484f1fd1cbab0aa.tar.bz2
doctor: be specific about libiconv files detected
Closes Homebrew/homebrew#11417.
Diffstat (limited to 'Library')
-rw-r--r--Library/Homebrew/cmd/doctor.rb15
1 files changed, 9 insertions, 6 deletions
diff --git a/Library/Homebrew/cmd/doctor.rb b/Library/Homebrew/cmd/doctor.rb
index 340d3ab3c..3a47b7133 100644
--- a/Library/Homebrew/cmd/doctor.rb
+++ b/Library/Homebrew/cmd/doctor.rb
@@ -500,17 +500,20 @@ def check_for_gettext
end
def check_for_iconv
- if %w[lib/libiconv.dylib
- include/iconv.h ].any? { |f| File.exist? "#{HOMEBREW_PREFIX}/#{f}" }
+ iconv_files = %w[lib/iconv.dylib
+ include/iconv.h].select { |f| File.exist? "#{HOMEBREW_PREFIX}/#{f}" }
+ if !iconv_files.empty?
<<-EOS.undent
- libiconv was detected in your PREFIX.
+ The following libiconv files were detected in #{HOMEBREW_PREFIX}:
+ #{iconv_files.join "\n "}
Homebrew doesn't provide a libiconv formula, and expects to link against
the system version in /usr/lib.
- If you have a non-Homebrew provided libiconv, many formulae will fail
- to compile or link, especially if it wasn't compiled with the proper
- architectures.
+ If you have an alternate libiconv, many formulae will fail to compile or
+ link, especially if it wasn't compiled with the proper architectures.
EOS
+ else
+ nil
end
end