Cache MacOS.version comparison results

MacOS.version#<=> is called many, many times during formula loading with
the same half dozen or so arguments. A typical call to this method
involves:

 * a hash lookup to convert a symbol argument to a string
 * creation of a throw-away Version object wrapping the argument
 * the actual version comparison, which is not cheap

This makes it a prime candidate to be memoized.

1 files changed, 9 insertions, 2 deletions

diff --git a/Library/Homebrew/os/mac/version.rb b/Library/Homebrew/os/mac/version.rb
index cfe42a75f..e19ecae70 100644
--- a/Library/Homebrew/os/mac/version.rb
+++ b/Library/Homebrew/os/mac/version.rb
@@ -16,9 +16,16 @@ module OS
         new(SYMBOLS.fetch(sym))
       end
 
+      def initialize(*args)
+        super
+        @comparison_cache = {}
+      end
+
       def <=>(other)
-        v = SYMBOLS.fetch(other, other.to_s)
-        super(Version.new(v))
+        @comparison_cache.fetch(other) do
+          v = SYMBOLS.fetch(other, other.to_s)
+          @comparison_cache[other] = super(Version.new(v))
+        end
       end
 
       def to_sym