diff options
| author | Dominyk Tiller | 2016-02-19 23:38:32 +0000 |
|---|---|---|
| committer | Dominyk Tiller | 2016-02-20 19:30:31 +0000 |
| commit | bfbdfe8d9da53209dcc66ee0e9980078669a4acd (patch) | |
| tree | d0ef08626900f12ca74904b517acb2083e9729ff /Library | |
| parent | 7572e91a6031dfc2c5d12d07686436aa44de501e (diff) | |
| download | brew-bfbdfe8d9da53209dcc66ee0e9980078669a4acd.tar.bz2 | |
env/shared: ignore perl opts
In theory, letting these be set once wasn't an awful idea because it allows
users choice on where Perl modules end up.
In reality, as we've moved closer to sandboxing and at the same time accepted more
perl binding options into formulae it has been exposed as something of a hellraiser.
It's not that uncommon for Perl users to set a custom `INSTALL_BASE` in the ENV which
means we end up with quite a few formula that fail hard with this sort of error:
```
Only one of PREFIX or INSTALL_BASE can be given. Not both.
```
The other common error, which we discovered via sandboxing, is that the Perl modules
end up outside Homebrew's control which means we don't automatically remove them
when the package is removed. Sandboxing blocks this, which means when we eventually
move to enable that by default for users as well as CI it'll quickly become a
prominent issue.
Diffstat (limited to 'Library')
| -rw-r--r-- | Library/Homebrew/extend/ENV/shared.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Library/Homebrew/extend/ENV/shared.rb b/Library/Homebrew/extend/ENV/shared.rb index 19af48698..2b5f51721 100644 --- a/Library/Homebrew/extend/ENV/shared.rb +++ b/Library/Homebrew/extend/ENV/shared.rb @@ -22,7 +22,7 @@ module SharedEnvExtension CFLAGS CXXFLAGS OBJCFLAGS OBJCXXFLAGS LDFLAGS CPPFLAGS MACOSX_DEPLOYMENT_TARGET SDKROOT DEVELOPER_DIR CMAKE_PREFIX_PATH CMAKE_INCLUDE_PATH CMAKE_FRAMEWORK_PATH - GOBIN GOPATH GOROOT + GOBIN GOPATH GOROOT PERL_MB_OPT PERL_MM_OPT LIBRARY_PATH ] |