diff options
| author | Jack Nagel | 2013-07-23 11:21:37 -0500 |
|---|---|---|
| committer | Jack Nagel | 2013-07-23 11:22:15 -0500 |
| commit | be984215c9b37f025dae36866382a26753f27cc9 (patch) | |
| tree | f82ca69595a6544cbb2c2c036de4e1b56af0c6f9 /Library | |
| parent | a3863394c0cbf38255d9b71cb589710729bbbcc6 (diff) | |
| download | brew-be984215c9b37f025dae36866382a26753f27cc9.tar.bz2 | |
audit: fix dep name escaping
Diffstat (limited to 'Library')
| -rw-r--r-- | Library/Homebrew/cmd/audit.rb | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/Library/Homebrew/cmd/audit.rb b/Library/Homebrew/cmd/audit.rb index a49d01e06..3f3e6f56c 100644 --- a/Library/Homebrew/cmd/audit.rb +++ b/Library/Homebrew/cmd/audit.rb @@ -511,12 +511,14 @@ class FormulaAuditor end def audit_conditional_dep(dep, condition, line) - dep = Regexp.escape(dep) + quoted_dep = quote_dep(dep) + dep = Regexp.escape(dep.to_s) + case condition when /if build\.include\? ['"]with-#{dep}['"]$/, /if build\.with\? ['"]#{dep}['"]$/ - problem %{Replace #{line.inspect} with "depends_on #{quote_dep(dep)} => :optional"} + problem %{Replace #{line.inspect} with "depends_on #{quoted_dep} => :optional"} when /unless build\.include\? ['"]without-#{dep}['"]$/, /unless build\.without\? ['"]#{dep}['"]$/ - problem %{Replace #{line.inspect} with "depends_on #{quote_dep(dep)} => :recommended"} + problem %{Replace #{line.inspect} with "depends_on #{quoted_dep} => :recommended"} end end |
