diff options
| author | Dominyk Tiller | 2016-04-04 17:41:39 +0100 |
|---|---|---|
| committer | Dominyk Tiller | 2016-04-05 23:57:53 +0100 |
| commit | a9c0361a1d83374059fca73485643e89c2772331 (patch) | |
| tree | 221702ab832ba9c74af018ed541400e2ac84329d /Library | |
| parent | 776a73da7c4b92c73dea3e5065ea4b2d9873f029 (diff) | |
| download | brew-a9c0361a1d83374059fca73485643e89c2772331.tar.bz2 | |
audit: require plist_options when using plist
Closes #19.
Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
Diffstat (limited to 'Library')
| -rw-r--r-- | Library/Homebrew/cmd/audit.rb | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/Library/Homebrew/cmd/audit.rb b/Library/Homebrew/cmd/audit.rb index 5f4d7cb0a..acc22f98a 100644 --- a/Library/Homebrew/cmd/audit.rb +++ b/Library/Homebrew/cmd/audit.rb @@ -638,6 +638,10 @@ class FormulaAuditor problem "\"Formula.factory(name)\" is deprecated in favor of \"Formula[name]\"" end + if text =~ /def plist/ && text !~ /plist_options/ + problem "Please set plist_options when using a formula-defined plist." + end + if text =~ /system "npm", "install"/ && text !~ %r[opt_libexec\}/npm/bin] && formula.name !~ /^kibana(\d{2})?$/ need_npm = "\#{Formula[\"node\"].opt_libexec\}/npm/bin" problem <<-EOS.undent |