diff options
| author | Mike McQuaid | 2016-12-29 11:46:49 +0000 |
|---|---|---|
| committer | Mike McQuaid | 2016-12-29 11:46:51 +0000 |
| commit | 8ffe231f44f18aeb482a213e50c3959a3f6405ab (patch) | |
| tree | 817f4eee4632cb05874279cfe3702f72aa05ab2c /Library | |
| parent | aaf70eb69656ab9f64a70c8daea4581c270766a6 (diff) | |
| download | brew-8ffe231f44f18aeb482a213e50c3959a3f6405ab.tar.bz2 | |
audit: don't allow openssl & libressl dependency.
Formulae should not depend on both OpenSSL and LibreSSL (even
optionally). This is to avoid descending into madness where every
formulae that could use LibreSSL has to have option and switching logic.
Homebrew has standardised on OpenSSL and will do so everywhere that
LibreSSL is not a hard requirement.
Diffstat (limited to 'Library')
| -rw-r--r-- | Library/Homebrew/dev-cmd/audit.rb | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/Library/Homebrew/dev-cmd/audit.rb b/Library/Homebrew/dev-cmd/audit.rb index 93431c951..ef22cbb7a 100644 --- a/Library/Homebrew/dev-cmd/audit.rb +++ b/Library/Homebrew/dev-cmd/audit.rb @@ -788,6 +788,10 @@ class FormulaAuditor problem "Please set plist_options when using a formula-defined plist." end + if text =~ /depends_on\s+['"]openssl['"]/ && text =~ /depends_on\s+['"]libressl['"]/ + problem "Formulae should not depend on both OpenSSL and LibreSSL (even optionally)." + end + return unless text.include?('require "language/go"') && !text.include?("go_resource") problem "require \"language/go\" is unnecessary unless using `go_resource`s" end |
