audit: Raise a problem if the SourceForge download url uses http instead of https

Signed-off-by: Adam Vandenberg <flangy@gmail.com>

1 files changed, 5 insertions, 1 deletions

diff --git a/Library/Homebrew/cmd/audit.rb b/Library/Homebrew/cmd/audit.rb
index 47b673c5f..c3db8a08a 100644
--- a/Library/Homebrew/cmd/audit.rb
+++ b/Library/Homebrew/cmd/audit.rb
@@ -223,7 +223,7 @@ class FormulaAuditor
       next if p =~ %r[svn\.sourceforge]
 
       # Is it a sourceforge http(s) URL?
-      next unless p =~ %r[^https?://.*\bsourceforge\.com]
+      next unless p =~ %r[^https?://.*\b(sourceforge|sf)\.(com|net)]
 
       if p =~ /(\?|&)use_mirror=/
         problem "Don't use #{$1}use_mirror in SourceForge urls (url is #{p})."
@@ -245,6 +245,10 @@ class FormulaAuditor
       if p =~ %r[^http://\w+\.dl\.]
         problem "Don't use specific dl mirrors in SourceForge urls (url is #{p})."
       end
+
+      if p.start_with? "http://downloads"
+        problem "Use https:// URLs for downloads from SourceForge (url is #{p})."
+      end
     end
 
     # Check for git:// GitHub repo urls, https:// is preferred.