diff options
| author | Max Howell | 2011-06-28 17:28:37 +0100 |
|---|---|---|
| committer | Max Howell | 2011-06-28 17:28:37 +0100 |
| commit | 870f36769ef747b4f8eb8d5444eb2739affb73a1 (patch) | |
| tree | 692e59ed8c62b544e85ba2c992b34965cb367bd2 /Library | |
| parent | 02b09e311f8d8934bfdff77d740ad20d0ea99f80 (diff) | |
| download | brew-870f36769ef747b4f8eb8d5444eb2739affb73a1.tar.bz2 | |
Fix install_name massaging for keg-only brews
Fixes Homebrew/homebrew#6065.
My pre-emptive fix that avoided calling Pathname.ensure_writable because I was not convinced it worked broke this function due to incorrect logic.
The lesson is, don’t write pre-emptive fixes. Wait until you've seen the bug first. All code has bugs in, so write less. I'm an idiot sometimes.
Diffstat (limited to 'Library')
| -rw-r--r-- | Library/Homebrew/keg_fix_install_names.rb | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/Library/Homebrew/keg_fix_install_names.rb b/Library/Homebrew/keg_fix_install_names.rb index c23f04adb..d3117b6f3 100644 --- a/Library/Homebrew/keg_fix_install_names.rb +++ b/Library/Homebrew/keg_fix_install_names.rb @@ -2,9 +2,6 @@ class Keg def fix_install_names dylibs.each do |dylib| bad_install_names_for dylib do |id, bad_names| - # avoid the chmod change if unecessary—I'm not convinced it reverses right - next if bad_names.empty? and id.to_s == dylib.to_s - dylib.ensure_writable do system "install_name_tool", "-id", id, dylib bad_names.each do |bad_name| |