diff options
| author | Jack Nagel | 2014-07-07 21:32:36 -0500 |
|---|---|---|
| committer | Jack Nagel | 2014-07-07 22:02:32 -0500 |
| commit | 7ee49db51e27b4403d3f24747262d9c9891c8477 (patch) | |
| tree | 08b24604f25cf703a5e6f90c9b5aa427c34f416d /Library | |
| parent | d4602b17119b70dbf7caabeb394bbb9b5726b2e5 (diff) | |
| download | brew-7ee49db51e27b4403d3f24747262d9c9891c8477.tar.bz2 | |
Remove proc handling from BuildEnvironment
Diffstat (limited to 'Library')
| -rw-r--r-- | Library/Homebrew/build_environment.rb | 31 | ||||
| -rw-r--r-- | Library/Homebrew/test/test_build_environment.rb | 25 |
2 files changed, 2 insertions, 54 deletions
diff --git a/Library/Homebrew/build_environment.rb b/Library/Homebrew/build_environment.rb index 618342a40..86a7fef50 100644 --- a/Library/Homebrew/build_environment.rb +++ b/Library/Homebrew/build_environment.rb @@ -1,8 +1,6 @@ require 'set' class BuildEnvironment - attr_accessor :proc - def initialize(*settings) @settings = Set.new(*settings) end @@ -24,36 +22,11 @@ class BuildEnvironment def userpaths? @settings.include? :userpaths end - - def modify_build_environment(receiver) - receiver.instance_eval(&proc) if self.proc - end - - def marshal_dump - @settings - end - - def marshal_load(data) - @settings = data - end - - def _dump(*) - Marshal.dump(marshal_dump) - end - - def self._load(s) - new(Marshal.load(s)) - end end module BuildEnvironmentDSL - def env(*settings, &block) + def env(*settings) @env ||= BuildEnvironment.new - if block_given? - @env.proc = block - else - @env.merge(settings) - end - @env + @env.merge(settings) end end diff --git a/Library/Homebrew/test/test_build_environment.rb b/Library/Homebrew/test/test_build_environment.rb index bd8c83451..879d45047 100644 --- a/Library/Homebrew/test/test_build_environment.rb +++ b/Library/Homebrew/test/test_build_environment.rb @@ -23,31 +23,6 @@ class BuildEnvironmentTests < Homebrew::TestCase @env << :userpaths assert_predicate @env, :userpaths? end - - def test_modify_build_environment - @env.proc = Proc.new { raise StandardError } - assert_raises(StandardError) do - @env.modify_build_environment(self) - end - end - - def test_marshal - @env << :userpaths - @env.proc = Proc.new {} - assert_predicate Marshal.load(Marshal.dump(@env)), :userpaths? - end - - def test_env_block - error = Class.new(StandardError) - @env.proc = Proc.new { raise error } - assert_raises(error) { @env.modify_build_environment(self) } - end - - def test_env_block_with_argument - error = Class.new(StandardError) - @env.proc = Proc.new { |x| raise x } - assert_raises(error) { @env.modify_build_environment(error) } - end end class BuildEnvironmentDSLTests < Homebrew::TestCase |
