aboutsummaryrefslogtreecommitdiffstats
path: root/Library
diff options
context:
space:
mode:
authorilovezfs2016-08-13 02:28:33 -0700
committerilovezfs2016-08-13 02:28:33 -0700
commit7c807d347e6cba62e708058481c6996adfcef683 (patch)
tree76c37b321356d7bbf6368321fef685350a0eca79 /Library
parent1e76a207b5bfacebee0a7198318230446be8da47 (diff)
downloadbrew-7c807d347e6cba62e708058481c6996adfcef683.tar.bz2
pull: non-core tap support for Homebrew Testing jobs
`test-bot --ci-testing` supports a `--tap` option for non-core taps, so `brew pull` should too when pulling Homebrew Testing jobs.
Diffstat (limited to 'Library')
-rw-r--r--Library/Homebrew/cmd/pull.rb11
1 files changed, 9 insertions, 2 deletions
diff --git a/Library/Homebrew/cmd/pull.rb b/Library/Homebrew/cmd/pull.rb
index f93ad095a..24abbd938 100644
--- a/Library/Homebrew/cmd/pull.rb
+++ b/Library/Homebrew/cmd/pull.rb
@@ -52,9 +52,16 @@ module Homebrew
url = "https://github.com/Homebrew/homebrew-core/pull/#{arg}"
tap = CoreTap.instance
elsif (testing_match = arg.match %r{brew\.sh/job/Homebrew.*Testing/(\d+)/})
+ tap = ARGV.value("tap")
+ tap = if tap && tap.start_with?("homebrew/")
+ Tap.fetch("homebrew", tap.strip_prefix("homebrew/"))
+ elsif tap
+ odie "Tap option did not start with \"homebrew/\": #{tap}"
+ else
+ CoreTap.instance
+ end
_, testing_job = *testing_match
- url = "https://github.com/Homebrew/homebrew-core/compare/master...BrewTestBot:testing-#{testing_job}"
- tap = CoreTap.instance
+ url = "https://github.com/Homebrew/homebrew-#{tap.repo}/compare/master...BrewTestBot:testing-#{testing_job}"
odie "Testing URLs require `--bottle`!" unless ARGV.include?("--bottle")
elsif (api_match = arg.match HOMEBREW_PULL_API_REGEX)
_, user, repo, issue = *api_match