aboutsummaryrefslogtreecommitdiffstats
path: root/Library
diff options
context:
space:
mode:
authorMarkus Reiter2017-02-08 11:24:43 +0100
committerGitHub2017-02-08 11:24:43 +0100
commit7137dad3d46c8fe2412475f7ba4cba105527d511 (patch)
tree3b0039065258ea0c43ca050feb20f4d0d3d0b114 /Library
parentbef2c6c9bd71e9b825ce34450fff79c7bb05a28f (diff)
parent9c623a273b967b8554ff5bd9b8debc2cf4c0cbd9 (diff)
downloadbrew-7137dad3d46c8fe2412475f7ba4cba105527d511.tar.bz2
Merge pull request #1971 from reitermarkus/sha256-helper
Remove `Sha256Helper`.
Diffstat (limited to 'Library')
-rw-r--r--Library/Homebrew/cask/spec/cask/audit_spec.rb3
-rw-r--r--Library/Homebrew/cask/spec/cask/verify/checksum_spec.rb8
-rw-r--r--Library/Homebrew/cask/spec/support/sha256_helper.rb8
3 files changed, 4 insertions, 15 deletions
diff --git a/Library/Homebrew/cask/spec/cask/audit_spec.rb b/Library/Homebrew/cask/spec/cask/audit_spec.rb
index 193b58fd6..9eb9f0136 100644
--- a/Library/Homebrew/cask/spec/cask/audit_spec.rb
+++ b/Library/Homebrew/cask/spec/cask/audit_spec.rb
@@ -1,6 +1,5 @@
describe Hbc::Audit do
include AuditMatchers
- include Sha256Helper
let(:cask) { instance_double(Hbc::Cask) }
let(:download) { false }
@@ -178,7 +177,7 @@ describe Hbc::Audit do
end
context "when appcast checkpoint is out of date" do
- let(:actual_checkpoint) { random_sha256 }
+ let(:actual_checkpoint) { "deadbeefdeadbeefdeadbeefdeadbeefdeadbeefdeadbeefdeadbeefdeadbeef" }
it { is_expected.to warn_with(mismatch_msg) }
it { should_not warn_with(curl_error_msg) }
end
diff --git a/Library/Homebrew/cask/spec/cask/verify/checksum_spec.rb b/Library/Homebrew/cask/spec/cask/verify/checksum_spec.rb
index a379dafb9..d803c566d 100644
--- a/Library/Homebrew/cask/spec/cask/verify/checksum_spec.rb
+++ b/Library/Homebrew/cask/spec/cask/verify/checksum_spec.rb
@@ -1,6 +1,4 @@
describe Hbc::Verify::Checksum do
- include Sha256Helper
-
let(:cask) { double("cask") }
let(:downloaded_path) { double("downloaded_path") }
let(:verification) { described_class.new(cask, downloaded_path) }
@@ -35,7 +33,7 @@ describe Hbc::Verify::Checksum do
end
context "sha256 is a valid shasum" do
- let(:sha256) { random_sha256 }
+ let(:sha256) { "deadbeefdeadbeefdeadbeefdeadbeefdeadbeefdeadbeefdeadbeefdeadbeef" }
it { is_expected.to be true }
end
@@ -44,7 +42,7 @@ describe Hbc::Verify::Checksum do
describe "#verify" do
subject { verification.verify }
- let(:computed) { random_sha256 }
+ let(:computed) { "deadbeefdeadbeefdeadbeefdeadbeefdeadbeefdeadbeefdeadbeefdeadbeef" }
before do
allow(verification).to receive(:computed).and_return(computed)
@@ -67,7 +65,7 @@ describe Hbc::Verify::Checksum do
end
context "sha256 does not match computed" do
- let(:sha256) { random_sha256 }
+ let(:sha256) { "d3adb33fd3adb33fd3adb33fd3adb33fd3adb33fd3adb33fd3adb33fd3adb33f" }
it "raises an error" do
expect { subject }.to raise_error(Hbc::CaskSha256MismatchError)
diff --git a/Library/Homebrew/cask/spec/support/sha256_helper.rb b/Library/Homebrew/cask/spec/support/sha256_helper.rb
deleted file mode 100644
index 14f2a2519..000000000
--- a/Library/Homebrew/cask/spec/support/sha256_helper.rb
+++ /dev/null
@@ -1,8 +0,0 @@
-require"digest"
-
-module Sha256Helper
- def random_sha256
- seed = "--#{rand(10_000)}--#{Time.now}--"
- Digest::SHA2.hexdigest(seed)
- end
-end