aboutsummaryrefslogtreecommitdiffstats
path: root/Library
diff options
context:
space:
mode:
authorAlyssa Ross2017-01-16 22:41:37 +0000
committerAlyssa Ross2017-01-16 23:04:26 +0000
commit36c1c8e9b0e5919a5165ffb5eaeddb54db1238b0 (patch)
tree7d2ef92d7edb99d3b87590fed6cc563b7d8da354 /Library
parent9dca10f9dc428e85afa399de4b76dbeac81a32b2 (diff)
downloadbrew-36c1c8e9b0e5919a5165ffb5eaeddb54db1238b0.tar.bz2
uses: fix recursive requirement resolution
Fixes #1848 by sharing recursive dependency resolution between dependencies and requirements. Coincidentally, this also fixes the errors introduced by #1784 that necessitated it being reverted in #1797.
Diffstat (limited to 'Library')
-rw-r--r--Library/Homebrew/cmd/uses.rb22
1 files changed, 18 insertions, 4 deletions
diff --git a/Library/Homebrew/cmd/uses.rb b/Library/Homebrew/cmd/uses.rb
index fb11a31a7..e5e140d36 100644
--- a/Library/Homebrew/cmd/uses.rb
+++ b/Library/Homebrew/cmd/uses.rb
@@ -58,15 +58,29 @@ module Homebrew
Dependency.prune unless includes.include?("build?")
end
end
- reqs = f.recursive_requirements do |dependent, req|
+
+ dep_formulae = deps.map do |dep|
+ begin
+ dep.to_formula
+ rescue
+ end
+ end.compact
+
+ reqs_by_formula = ([f] + dep_formulae).flat_map do |formula|
+ formula.requirements.map { |req| [formula, req] }
+ end
+
+ reqs_by_formula.reject! do |dependent, req|
if req.recommended?
- Requirement.prune if ignores.include?("recommended?") || dependent.build.without?(req)
+ ignores.include?("recommended?") || dependent.build.without?(req)
elsif req.optional?
- Requirement.prune if !includes.include?("optional?") && !dependent.build.with?(req)
+ !includes.include?("optional?") && !dependent.build.with?(req)
elsif req.build?
- Requirement.prune unless includes.include?("build?")
+ !includes.include?("build?")
end
end
+
+ reqs = reqs_by_formula.map(&:last)
else
deps = f.deps.reject do |dep|
ignores.any? { |ignore| dep.send(ignore) } && !includes.any? { |include| dep.send(include) }