aboutsummaryrefslogtreecommitdiffstats
path: root/Library
diff options
context:
space:
mode:
authorMike McQuaid2016-12-13 02:32:38 +0000
committerMike McQuaid2016-12-18 15:30:06 -0800
commit339ff9400f32e87eec5bde75801d55cf674adca7 (patch)
treef8fd532151d44ec6060fcce88f4aec92ba647e06 /Library
parent201b45d2cace5237b555a56af30703e3fd1fc4c2 (diff)
downloadbrew-339ff9400f32e87eec5bde75801d55cf674adca7.tar.bz2
audit: don't allow use of OS.mac?/OS.linux?.
Forbid their use in Homebrew/core which only supports macOS. This may be added to more/all official taps in future.
Diffstat (limited to 'Library')
-rw-r--r--Library/Homebrew/dev-cmd/audit.rb7
1 files changed, 7 insertions, 0 deletions
diff --git a/Library/Homebrew/dev-cmd/audit.rb b/Library/Homebrew/dev-cmd/audit.rb
index 0112c524f..540925947 100644
--- a/Library/Homebrew/dev-cmd/audit.rb
+++ b/Library/Homebrew/dev-cmd/audit.rb
@@ -1004,6 +1004,13 @@ class FormulaAuditor
problem "'fails_with :llvm' is now a no-op so should be removed"
end
+ if formula.tap.to_s == "homebrew/core"
+ ["OS.mac?", "OS.linux?"].each do |check|
+ next unless line.include?(check)
+ problem "Don't use #{check}; Homebrew/core only supports macOS"
+ end
+ end
+
return unless @strict
if line =~ /system ((["'])[^"' ]*(?:\s[^"' ]*)+\2)/