aboutsummaryrefslogtreecommitdiffstats
path: root/Library
diff options
context:
space:
mode:
authorVítor Galvão2017-01-02 17:49:50 +0000
committerGitHub2017-01-02 17:49:50 +0000
commit2eed2ba43448e7233f5c9fa40eefb2540da6361e (patch)
tree52ad17e37229c43688749429965e7606cd60fc07 /Library
parent814a5de7f74f3012f364aef978394955cbef7ac5 (diff)
parent2c6516ef59747ae8af91922d289c5ba1f3160ad2 (diff)
downloadbrew-2eed2ba43448e7233f5c9fa40eefb2540da6361e.tar.bz2
Merge pull request #1760 from reitermarkus/version-file-separator
Disallow file separator in version strings.
Diffstat (limited to 'Library')
-rw-r--r--Library/Homebrew/cask/lib/hbc/audit.rb8
1 files changed, 8 insertions, 0 deletions
diff --git a/Library/Homebrew/cask/lib/hbc/audit.rb b/Library/Homebrew/cask/lib/hbc/audit.rb
index ab2f1bce5..955ecdbb0 100644
--- a/Library/Homebrew/cask/lib/hbc/audit.rb
+++ b/Library/Homebrew/cask/lib/hbc/audit.rb
@@ -60,6 +60,7 @@ module Hbc
def check_version
return unless cask.version
check_no_string_version_latest
+ check_no_file_separator_in_version
end
def check_no_string_version_latest
@@ -68,6 +69,13 @@ module Hbc
add_error "you should use version :latest instead of version 'latest'"
end
+ def check_no_file_separator_in_version
+ odebug "Verifying version does not contain '#{File::SEPARATOR}'"
+ return unless cask.version.raw_version.is_a?(String)
+ return unless cask.version.raw_version.include?(File::SEPARATOR)
+ add_error "version should not contain '#{File::SEPARATOR}'"
+ end
+
def check_sha256
return unless cask.sha256
check_sha256_no_check_if_latest