aboutsummaryrefslogtreecommitdiffstats
path: root/Library
diff options
context:
space:
mode:
authorMarkus Reiter2017-02-16 17:10:40 +0100
committerMarkus Reiter2017-02-16 17:12:38 +0100
commit2a21991b1fc8039bfa0c950e439db5a725b62b42 (patch)
tree60455ceac57c0074f8e3a87d2a17b8dbe24d8846 /Library
parent5a2a0638028ee49991e404c1bd6397c10659474b (diff)
downloadbrew-2a21991b1fc8039bfa0c950e439db5a725b62b42.tar.bz2
Make sure `uninstall` is called before artifacts are removed.
Diffstat (limited to 'Library')
-rw-r--r--Library/Homebrew/cask/lib/hbc/installer.rb6
1 files changed, 6 insertions, 0 deletions
diff --git a/Library/Homebrew/cask/lib/hbc/installer.rb b/Library/Homebrew/cask/lib/hbc/installer.rb
index cafc9d8b9..b86f3264d 100644
--- a/Library/Homebrew/cask/lib/hbc/installer.rb
+++ b/Library/Homebrew/cask/lib/hbc/installer.rb
@@ -318,7 +318,13 @@ module Hbc
def uninstall_artifacts
odebug "Un-installing artifacts"
artifacts = Artifact.for_cask(@cask, command: @command, force: force)
+
+ # Make sure the `uninstall` stanza is run first, as it
+ # may depend on other artifacts still being installed.
+ artifacts = artifacts.sort_by { |a| a.is_a?(Artifact::Uninstall) ? -1 : 1 }
+
odebug "#{artifacts.length} artifact/s defined", artifacts
+
artifacts.each do |artifact|
next unless artifact.respond_to?(:uninstall_phase)
odebug "Un-installing artifact of class #{artifact.class}"