aboutsummaryrefslogtreecommitdiffstats
path: root/Library
diff options
context:
space:
mode:
authorTobias Lidskog2013-02-21 09:56:30 +0100
committerJack Nagel2013-03-09 14:42:51 -0600
commit23575f3c7f4dc79129957f7dfb88ed11aa1619c0 (patch)
treeafab86922f22947a6dd8f5117888e886299a6ca7 /Library
parent04dfdd972c7fca25e86e9e2ff7767b9f5b789f20 (diff)
downloadbrew-23575f3c7f4dc79129957f7dfb88ed11aa1619c0.tar.bz2
audit: correct inverted has_trailing_newline condition
has_trailing_newline? checked if formula did not have a trailing newline. Invert regex and invert audit check. Closes Homebrew/homebrew#18359. Signed-off-by: Jack Nagel <jacknagel@gmail.com>
Diffstat (limited to 'Library')
-rw-r--r--Library/Homebrew/cmd/audit.rb4
1 files changed, 2 insertions, 2 deletions
diff --git a/Library/Homebrew/cmd/audit.rb b/Library/Homebrew/cmd/audit.rb
index 3b1733e0b..74f18c367 100644
--- a/Library/Homebrew/cmd/audit.rb
+++ b/Library/Homebrew/cmd/audit.rb
@@ -68,7 +68,7 @@ class FormulaText
end
def has_trailing_newline?
- /.+\z/ =~ @text
+ /\Z\n/ =~ @text
end
end
@@ -112,7 +112,7 @@ class FormulaAuditor
problem "'__END__' was found, but 'DATA' is not used"
end
- if f.text.has_trailing_newline?
+ unless f.text.has_trailing_newline?
problem "File should end with a newline"
end
end