aboutsummaryrefslogtreecommitdiffstats
path: root/Library
diff options
context:
space:
mode:
authorMike McQuaid2016-09-24 18:59:45 +0100
committerGitHub2016-09-24 18:59:45 +0100
commit210de2916b090cf7d5828cadbaab58e42a36a073 (patch)
tree81966f3ca02086406c7ab61f9e547cd787b7a315 /Library
parent2f82837b77e8539c536051010ea398b1f60e9c23 (diff)
parent5b4b7b24e6673567b8d6eb1f5f0e031f295e602b (diff)
downloadbrew-210de2916b090cf7d5828cadbaab58e42a36a073.tar.bz2
Merge pull request #1120 from MikeMcQuaid/alpha-beta-versions
version: don't let a/b imply alpha/beta.
Diffstat (limited to 'Library')
-rw-r--r--Library/Homebrew/test/test_versions.rb2
-rw-r--r--Library/Homebrew/version.rb4
2 files changed, 4 insertions, 2 deletions
diff --git a/Library/Homebrew/test/test_versions.rb b/Library/Homebrew/test/test_versions.rb
index 307bf6ead..21bf324a3 100644
--- a/Library/Homebrew/test/test_versions.rb
+++ b/Library/Homebrew/test/test_versions.rb
@@ -63,6 +63,8 @@ class VersionComparisonTests < Homebrew::TestCase
end
def test_comparing_alpha_versions
+ assert_operator version("1.2.3alpha"), :<, version("1.2.3")
+ assert_operator version("1.2.3"), :<, version("1.2.3a")
assert_operator version("1.2.3alpha4"), :==, version("1.2.3a4")
assert_operator version("1.2.3alpha4"), :==, version("1.2.3A4")
assert_operator version("1.2.3alpha4"), :>, version("1.2.3alpha3")
diff --git a/Library/Homebrew/version.rb b/Library/Homebrew/version.rb
index 00fe2f490..60a833609 100644
--- a/Library/Homebrew/version.rb
+++ b/Library/Homebrew/version.rb
@@ -95,7 +95,7 @@ class Version
end
class AlphaToken < CompositeToken
- PATTERN = /a(?:lpha)?[0-9]*/i
+ PATTERN = /alpha[0-9]*|a[0-9]+/i
def <=>(other)
case other
@@ -108,7 +108,7 @@ class Version
end
class BetaToken < CompositeToken
- PATTERN = /b(?:eta)?[0-9]*/i
+ PATTERN = /beta[0-9]*|b[0-9]+/i
def <=>(other)
case other