aboutsummaryrefslogtreecommitdiffstats
path: root/Library
diff options
context:
space:
mode:
authorJack Nagel2013-09-07 22:17:52 -0500
committerJack Nagel2013-09-07 22:20:26 -0500
commit20ed26c655601006ba06e558e5c3cb9962e51546 (patch)
treed1282da2be952337cba53e4b55ce6e64f122c33f /Library
parent4eb31ac676f0980992af1c7c36965228068f00fe (diff)
downloadbrew-20ed26c655601006ba06e558e5c3cb9962e51546.tar.bz2
Close read pipe immediately after reading and only when initialized
c.f. Homebrew/homebrew#22386.
Diffstat (limited to 'Library')
-rw-r--r--Library/Homebrew/formula_installer.rb3
1 files changed, 1 insertions, 2 deletions
diff --git a/Library/Homebrew/formula_installer.rb b/Library/Homebrew/formula_installer.rb
index 26a1b175f..91766bbea 100644
--- a/Library/Homebrew/formula_installer.rb
+++ b/Library/Homebrew/formula_installer.rb
@@ -417,6 +417,7 @@ class FormulaInstaller
write.close
Process.wait
data = read.read
+ read.close
raise Marshal.load(data) unless data.nil? or data.empty?
raise Interrupt if $?.exitstatus == 130
raise "Suspicious installation failure" unless $?.success?
@@ -431,8 +432,6 @@ class FormulaInstaller
f.rack.rmdir_if_possible
end
raise
- ensure
- read.close
end
def link