diff options
| author | Mike McQuaid | 2017-04-22 13:00:36 +0100 |
|---|---|---|
| committer | Mike McQuaid | 2017-04-22 13:00:38 +0100 |
| commit | 185b1787c61d6201f38e5fabad397cdaeb0a6762 (patch) | |
| tree | 3f9075a20b60b1975ae43a40d17ecde208bdcdd5 /Library | |
| parent | 10d70aa93a25b80efe3581cf82e789f05716517d (diff) | |
| download | brew-185b1787c61d6201f38e5fabad397cdaeb0a6762.tar.bz2 | |
audit: lookup unversioned formulae with Formulary.
This means that if e.g. the unversioned formulae exists in another tap
this audit won't produce a false positive.
Diffstat (limited to 'Library')
| -rw-r--r-- | Library/Homebrew/dev-cmd/audit.rb | 13 |
1 files changed, 12 insertions, 1 deletions
diff --git a/Library/Homebrew/dev-cmd/audit.rb b/Library/Homebrew/dev-cmd/audit.rb index 07d2e71cb..f3bfb4c0c 100644 --- a/Library/Homebrew/dev-cmd/audit.rb +++ b/Library/Homebrew/dev-cmd/audit.rb @@ -336,7 +336,18 @@ class FormulaAuditor problem "File should end with a newline" unless text.trailing_newline? if formula.versioned_formula? - unversioned_formula = Pathname.new formula.path.to_s.gsub(/@.*\.rb$/, ".rb") + unversioned_formula = begin + # build this ourselves as we want e.g. homebrew/core to be present + full_name = if formula.tap + "#{formula.tap}/#{formula.name}" + else + formula.name + end + Formulary.factory(full_name.gsub(/@.*$/, "")).path + rescue FormulaUnavailableError, TapFormulaAmbiguityError, + TapFormulaWithOldnameAmbiguityError + Pathname.new formula.path.to_s.gsub(/@.*\.rb$/, ".rb") + end unless unversioned_formula.exist? unversioned_name = unversioned_formula.basename(".rb") problem "#{formula} is versioned but no #{unversioned_name} formula exists" |
