aboutsummaryrefslogtreecommitdiffstats
path: root/Library
diff options
context:
space:
mode:
authorJack Nagel2013-05-22 19:42:43 -0500
committerJack Nagel2013-05-22 19:42:43 -0500
commit0bf35a05a9140cf5da59f236927a07cd689fd123 (patch)
treeb12e9ba61ace7652a190be13246af5dd8482fc8d /Library
parentda2b5cf5abd7a432892c4c7f5230849986eae2ee (diff)
downloadbrew-0bf35a05a9140cf5da59f236927a07cd689fd123.tar.bz2
Favor equality check over nil check
Diffstat (limited to 'Library')
-rw-r--r--Library/Homebrew/keg_fix_install_names.rb5
1 files changed, 3 insertions, 2 deletions
diff --git a/Library/Homebrew/keg_fix_install_names.rb b/Library/Homebrew/keg_fix_install_names.rb
index 3e9f7cdaa..c5a2ab9ea 100644
--- a/Library/Homebrew/keg_fix_install_names.rb
+++ b/Library/Homebrew/keg_fix_install_names.rb
@@ -8,7 +8,7 @@ class Keg
bad_names.each do |bad_name|
new_name = fixed_name(file, bad_name)
- unless new_name.nil?
+ unless new_name == bad_name
install_name_tool("-change", bad_name, new_name, file)
end
end
@@ -61,7 +61,8 @@ class Keg
elsif (abs_name = find_dylib(Pathname.new(bad_name).basename)) && abs_name.exist?
abs_name.to_s
else
- opoo "Could not fix install names for #{file}"
+ opoo "Could not fix #{bad_name} in #{file}"
+ bad_name
end
end