Warn when overriding ScriptFileFormula#install

ScriptFileFormula's use is that it installs whatever was downloaded
to bin; if the install is overridden, there's no benefit over deriving
directly from Formula.

1 files changed, 8 insertions, 0 deletions

diff --git a/Library/Homebrew/formula_specialties.rb b/Library/Homebrew/formula_specialties.rb
index 2529243b2..e91c02dc0 100644
--- a/Library/Homebrew/formula_specialties.rb
+++ b/Library/Homebrew/formula_specialties.rb
@@ -5,6 +5,14 @@ class ScriptFileFormula < Formula
   def install
     bin.install Dir['*']
   end
+
+  def self.method_added method
+    super method
+    case method
+    when :install
+      opoo "#{name}: if you are overriding ScriptFileFormula#install, use a Formula instead"
+    end
+  end
 end
 
 # See browser for an example