diff options
| author | Alyssa Ross | 2016-12-30 22:16:18 +0000 |
|---|---|---|
| committer | Alyssa Ross | 2016-12-30 22:22:13 +0000 |
| commit | b0a38c06bfce65292dafd8e43e04d9630d236218 (patch) | |
| tree | 51f5fdfa40b7c60d36be25a0d30e4db408f514d2 /Library/Homebrew | |
| parent | 01e1f7d49e91b6f02037997ffb465b37d2426b80 (diff) | |
| download | brew-b0a38c06bfce65292dafd8e43e04d9630d236218.tar.bz2 | |
docs: improve Keg.find_some_installed_dependencies
See https://github.com/Homebrew/brew/pull/1752#discussion_r94257147
Diffstat (limited to 'Library/Homebrew')
| -rw-r--r-- | Library/Homebrew/keg.rb | 17 |
1 files changed, 14 insertions, 3 deletions
diff --git a/Library/Homebrew/keg.rb b/Library/Homebrew/keg.rb index 43e2cbc4f..bdb618ba2 100644 --- a/Library/Homebrew/keg.rb +++ b/Library/Homebrew/keg.rb @@ -87,11 +87,23 @@ class Keg mime-info pixmaps sounds postgresql ].freeze - # Will return some kegs, and some dependencies, if they're present. + # Given an array of kegs, this method will try to find some other kegs + # that depend on them. + # + # If it does, it returns: + # - some kegs in the passed array that have installed dependents + # - some installed dependents of those kegs. + # + # If it doesn't, it returns nil. + # + # Note that nil will be returned if the only installed dependents + # in the passed kegs are other kegs in the array. + # # For efficiency, we don't bother trying to get complete data. def self.find_some_installed_dependents(kegs) # First, check in the tabs of installed Formulae. kegs.each do |keg| + # Don't include dependencies of kegs that were in the given array. dependents = keg.installed_dependents - kegs dependents.map! { |d| "#{d.name} #{d.version}" } return [keg], dependents if dependents.any? @@ -107,8 +119,7 @@ class Keg remaining_formulae = Formula.installed.select do |f| installed_kegs = f.installed_kegs - # All installed kegs are going to be removed anyway, - # so it doesn't matter what they depend on. + # Don't include dependencies of kegs that were in the given array. next false if (installed_kegs - kegs).empty? installed_kegs.any? { |k| Tab.for_keg(k).runtime_dependencies.nil? } |
