diff options
| author | Jack Nagel | 2013-04-22 15:06:42 -0500 |
|---|---|---|
| committer | Jack Nagel | 2013-04-22 15:19:03 -0500 |
| commit | 8a74e648e7dea3a350ac9b8f1054d60df34dc160 (patch) | |
| tree | 9f145c4a860dec323b07d0cce46bdff5c099ac36 /Library/Homebrew | |
| parent | 4f45077fdee34243f2506ce6328a6d16f8330019 (diff) | |
| download | brew-8a74e648e7dea3a350ac9b8f1054d60df34dc160.tar.bz2 | |
audit: warn about top-level methods
Diffstat (limited to 'Library/Homebrew')
| -rw-r--r-- | Library/Homebrew/cmd/audit.rb | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/Library/Homebrew/cmd/audit.rb b/Library/Homebrew/cmd/audit.rb index 8b773345d..2ed56da80 100644 --- a/Library/Homebrew/cmd/audit.rb +++ b/Library/Homebrew/cmd/audit.rb @@ -442,6 +442,10 @@ class FormulaAuditor if text =~ /depends_on [A-Z][\w:]+\.new$/ problem "`depends_on` can take requirement classes instead of instances" end + + if text =~ /^def (\w+).*$/ + problem "Define method #{$1.inspect} in the class body, not at the top-level" + end end def audit |
