formula_installer: need up to date req formulae.

This makes them behave consistently to other dependencies. Otherwise
other checks for them being `installed?` will fail.

Fixes #2333
Closes #2302
Fixes https://github.com/Homebrew/homebrew-science/issues/5247

1 files changed, 5 insertions, 2 deletions

diff --git a/Library/Homebrew/formula_installer.rb b/Library/Homebrew/formula_installer.rb
index 1f91ad5c4..fa46a30f4 100644
--- a/Library/Homebrew/formula_installer.rb
+++ b/Library/Homebrew/formula_installer.rb
@@ -410,10 +410,13 @@ class FormulaInstaller
   end
 
   def install_requirement_formula?(req, dependent, build)
-    return false unless req.to_dependency
+    req_dependency = req.to_dependency
+    return false unless req_dependency
     return true unless req.satisfied?
     return false if req.run?
-    install_bottle_for?(dependent, build) || build_bottle?
+    return true if build_bottle?
+    return true unless req_dependency.installed?
+    install_bottle_for?(dependent, build)
   end
 
   def expand_requirements