aboutsummaryrefslogtreecommitdiffstats
path: root/Library/Homebrew
diff options
context:
space:
mode:
authorJack Nagel2013-07-21 19:11:06 -0500
committerJack Nagel2013-07-22 11:25:11 -0500
commit34623b4ef1ac360855e1e3e2d7217b21820ee63f (patch)
treeb04799731996536adcff688f869c4e7f72c5e87d /Library/Homebrew
parentd355227036f0e090158a5caa5f4a102bd2fccefc (diff)
downloadbrew-34623b4ef1ac360855e1e3e2d7217b21820ee63f.tar.bz2
Fall back on pkgutil when mdls cannot determine XQuartz version
Diffstat (limited to 'Library/Homebrew')
-rw-r--r--Library/Homebrew/os/mac/xquartz.rb7
1 files changed, 4 insertions, 3 deletions
diff --git a/Library/Homebrew/os/mac/xquartz.rb b/Library/Homebrew/os/mac/xquartz.rb
index ed7473cef..b1bd45d2c 100644
--- a/Library/Homebrew/os/mac/xquartz.rb
+++ b/Library/Homebrew/os/mac/xquartz.rb
@@ -11,8 +11,8 @@ module MacOS::XQuartz extend self
end
def detect_version
- if (path = bundle_path) && path.exist?
- version_from_mdls(path)
+ if (path = bundle_path) && path.exist? && (version = version_from_mdls(path))
+ version
elsif prefix.to_s == "/usr/X11"
guess_system_version
else
@@ -29,7 +29,8 @@ module MacOS::XQuartz extend self
end
def version_from_mdls(path)
- `mdls -raw -name kMDItemVersion "#{path}" 2>/dev/null`.strip
+ version = `mdls -raw -nullMarker "" -name kMDItemVersion "#{path}" 2>/dev/null`.strip
+ version unless version.empty?
end
# The XQuartz that Apple shipped in OS X through 10.7 does not have a