diff options
| author | Jack Nagel | 2014-02-27 21:47:38 -0600 |
|---|---|---|
| committer | Jack Nagel | 2014-02-27 21:53:33 -0600 |
| commit | 26c71b19f6f715e1f558da1c904aafe6eecebe11 (patch) | |
| tree | 3875a227869335179b8b32b6c48344be2e2aec57 /Library/Homebrew | |
| parent | c72f9a469d21899338ba5b23c4c8d97f4c03dcd8 (diff) | |
| download | brew-26c71b19f6f715e1f558da1c904aafe6eecebe11.tar.bz2 | |
Add audit check for system "xcodebuild"
Diffstat (limited to 'Library/Homebrew')
| -rw-r--r-- | Library/Homebrew/cmd/audit.rb | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/Library/Homebrew/cmd/audit.rb b/Library/Homebrew/cmd/audit.rb index edeb03d03..3a8aa876f 100644 --- a/Library/Homebrew/cmd/audit.rb +++ b/Library/Homebrew/cmd/audit.rb @@ -296,8 +296,12 @@ class FormulaAuditor problem "use \"scons *args\" instead of \"system 'scons', *args\"" end - if text =~ /system\s+['"]xcodebuild/ && text !~ /SYMROOT=/ - problem "xcodebuild should be passed an explicit \"SYMROOT\"" + if text =~ /system\s+['"]xcodebuild/ + problem %{use "xcodebuild *args" instead of "system 'xcodebuild', *args"} + end + + if text =~ /xcodebuild[ (]["'*]/ && text !~ /SYMROOT=/ + problem %{xcodebuild should be passed an explicit "SYMROOT"} end if text =~ /Formula\.factory\(/ |