diff options
| author | Xu Cheng | 2016-08-05 22:01:32 +0800 |
|---|---|---|
| committer | GitHub | 2016-08-05 22:01:32 +0800 |
| commit | a8566c9848122474b92fc8989eec196d5f4fb69b (patch) | |
| tree | 896c040fb575962be0aeb27bc9a99454f3514d73 /Library/Homebrew/utils/github.rb | |
| parent | 38209aadbfe4fd0c6772467c4bc5c63325d53f6c (diff) | |
| download | brew-a8566c9848122474b92fc8989eec196d5f4fb69b.tar.bz2 | |
various: eliminate the usage of `any?` (#638)
`any?` is not the opposite of `empty?`. Besides the case that
`[false, nil].any?` will return false, `any?`(O(n)) has much worse
performance than `empty?`(O(1)).
Diffstat (limited to 'Library/Homebrew/utils/github.rb')
| -rw-r--r-- | Library/Homebrew/utils/github.rb | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/Library/Homebrew/utils/github.rb b/Library/Homebrew/utils/github.rb index c7e43ec07..fce89f1af 100644 --- a/Library/Homebrew/utils/github.rb +++ b/Library/Homebrew/utils/github.rb @@ -259,10 +259,10 @@ module GitHub open_or_closed_prs = issues_matching(query, :type => "pr") open_prs = open_or_closed_prs.select { |i| i["state"] == "open" } - if open_prs.any? + if !open_prs.empty? puts "Open pull requests:" prs = open_prs - elsif open_or_closed_prs.any? + elsif !open_or_closed_prs.empty? puts "Closed pull requests:" prs = open_or_closed_prs else |