aboutsummaryrefslogtreecommitdiffstats
path: root/Library/Homebrew/utils.rb
diff options
context:
space:
mode:
authorJack Nagel2013-09-30 21:36:38 -0500
committerJack Nagel2013-09-30 22:56:02 -0500
commit57560c03e64cb11a33287b3194b0c35cbea6e159 (patch)
treeb05c9ec0c177069fdf00ac1ed45d752dba043724 /Library/Homebrew/utils.rb
parent48dde74503d61b6b9702aea0705202635124d93b (diff)
downloadbrew-57560c03e64cb11a33287b3194b0c35cbea6e159.tar.bz2
Handle invalid names in download strategies
When subformulae are initialized without a name parameter, Homebrew assigns the name "__UNKNOWN__". This may cause collisions in the cache. Currently CurlDownloadStrategy and its descendants handles this by extracting the basename form the URL and using that as the cached filename. However, other strategies simply raise an exception. We can improve the other strategies by URL-encoding the URL string and using that as the cached directory name. Note that this happens very rarely, especially now that resources (which always have a name) are preferred to subformulae. The most common case is a subformula that specifies a head download. Closes Homebrew/homebrew#22949.
Diffstat (limited to 'Library/Homebrew/utils.rb')
0 files changed, 0 insertions, 0 deletions