Deprecate default_formula Requirement DSL

This has been a nightmare in terms of the complexity to our dependency
system and the whack-a-mole required on bugs. If a Requirement resolves
to a Formula it should just use `depends_on "formula"` instead. This
matches the effective behaviour all users of bottles (the vast majority
of users and installs) and what we're doing in Homebrew/homebrew-core.

2 files changed, 0 insertions, 115 deletions

diff --git a/Library/Homebrew/test/formula_installer_spec.rb b/Library/Homebrew/test/formula_installer_spec.rb
index d3710a4cb..93f23b18f 100644
--- a/Library/Homebrew/test/formula_installer_spec.rb
+++ b/Library/Homebrew/test/formula_installer_spec.rb
@@ -132,64 +132,4 @@ describe FormulaInstaller do
       fi.check_install_sanity
     }.to raise_error(CannotInstallFormulaError)
   end
-
-  describe "#install_requirement_formula?", :needs_compat do
-    before do
-      @requirement = Python3Requirement.new
-      @requirement_dependency = @requirement.to_dependency
-      @install_bottle_for_dependent = false
-      allow(@requirement).to receive(:satisfied?).and_return(satisfied?)
-      allow(@requirement).to receive(:satisfied_by_formula?).and_return(satisfied_by_formula?)
-      allow(@requirement).to receive(:build?).and_return(build?)
-      @dependent = formula do
-        url "foo"
-        version "0.1"
-        depends_on :python3
-      end
-      allow(@dependent).to receive(:installed?).and_return(installed?)
-      @fi = FormulaInstaller.new(@dependent)
-    end
-
-    subject { @fi.install_requirement_formula?(@requirement_dependency, @requirement, @dependent, @install_bottle_for_dependent) }
-
-    context "it returns false when requirement is satisfied" do
-      let(:satisfied?) { true }
-      let(:satisfied_by_formula?) { false }
-      let(:build?) { false }
-      let(:installed?) { false }
-      it { is_expected.to be false }
-    end
-
-    context "it returns false when requirement is satisfied but default formula is installed" do
-      let(:satisfied?) { true }
-      let(:satisfied_by_formula?) { false }
-      let(:build?) { false }
-      let(:installed?) { false }
-      it { is_expected.to be false }
-    end
-
-    context "it returns false when requirement is :build and dependent is installed" do
-      let(:satisfied?) { false }
-      let(:satisfied_by_formula?) { false }
-      let(:build?) { true }
-      let(:installed?) { true }
-      it { is_expected.to be false }
-    end
-
-    context "it returns true when requirement isn't satisfied" do
-      let(:satisfied?) { false }
-      let(:satisfied_by_formula?) { false }
-      let(:build?) { false }
-      let(:installed?) { false }
-      it { is_expected.to be true }
-    end
-
-    context "it returns true when requirement is satisfied by a formula" do
-      let(:satisfied?) { true }
-      let(:satisfied_by_formula?) { true }
-      let(:build?) { false }
-      let(:installed?) { false }
-      it { is_expected.to be true }
-    end
-  end
 end
diff --git a/Library/Homebrew/test/requirement_spec.rb b/Library/Homebrew/test/requirement_spec.rb
index 2d0d86c86..1f3d872f3 100644
--- a/Library/Homebrew/test/requirement_spec.rb
+++ b/Library/Homebrew/test/requirement_spec.rb
@@ -2,7 +2,6 @@ require "extend/ENV"
 require "requirement"
 
 describe Requirement do
-  alias_matcher :have_a_default_formula, :be_a_default_formula
   alias_matcher :be_a_build_requirement, :be_a_build
 
   subject { klass.new }
@@ -173,60 +172,6 @@ describe Requirement do
     its(:option_names) { are_expected.to eq(["foo"]) }
   end
 
-  describe "#default_formula?" do
-    context "#default_formula specified" do
-      let(:klass) do
-        Class.new(described_class) do
-          default_formula "foo"
-        end
-      end
-
-      it { is_expected.to have_a_default_formula }
-    end
-
-    context "#default_formula omitted" do
-      it { is_expected.not_to have_a_default_formula }
-    end
-  end
-
-  describe "#to_dependency" do
-    let(:klass) do
-      Class.new(described_class) do
-        default_formula "foo"
-      end
-    end
-
-    it "returns a Dependency for its default Formula" do
-      expect(subject.to_dependency).to eq(Dependency.new("foo"))
-    end
-
-    context "#modify_build_environment" do
-      context "with error" do
-        let(:klass) do
-          Class.new(described_class) do
-            class ModifyBuildEnvironmentError < StandardError; end
-
-            default_formula "foo"
-
-            satisfy do
-              true
-            end
-
-            env do
-              raise ModifyBuildEnvironmentError
-            end
-          end
-        end
-
-        it "raises an error" do
-          expect {
-            subject.to_dependency.modify_build_environment
-          }.to raise_error(klass.const_get(:ModifyBuildEnvironmentError))
-        end
-      end
-    end
-  end
-
   describe "#modify_build_environment" do
     context "without env proc" do
       let(:klass) { Class.new(described_class) }