aboutsummaryrefslogtreecommitdiffstats
path: root/Library/Homebrew/test
diff options
context:
space:
mode:
authorMike McQuaid2017-01-18 08:36:36 +0000
committerMike McQuaid2017-01-18 08:36:36 +0000
commit4d2201b8beabf99a1f4bf062a5aef12b19475caa (patch)
tree7d1cdfdf8099819630cccf57f49cb2799d354cca /Library/Homebrew/test
parent9f183be3587ada8e99150fda96fd59cfc01f1bae (diff)
downloadbrew-4d2201b8beabf99a1f4bf062a5aef12b19475caa.tar.bz2
integration_command_test_case: improve fail output
Instead of `puts`ing when the failure occurs save it until the error message and print a prose description of what the failure was and the output from the command. This makes the output from failing tests significantly easier to read.
Diffstat (limited to 'Library/Homebrew/test')
-rw-r--r--Library/Homebrew/test/support/helper/integration_command_test_case.rb12
1 files changed, 8 insertions, 4 deletions
diff --git a/Library/Homebrew/test/support/helper/integration_command_test_case.rb b/Library/Homebrew/test/support/helper/integration_command_test_case.rb
index b79fdd6e0..6879f2f81 100644
--- a/Library/Homebrew/test/support/helper/integration_command_test_case.rb
+++ b/Library/Homebrew/test/support/helper/integration_command_test_case.rb
@@ -106,16 +106,20 @@ class IntegrationCommandTestCase < Homebrew::TestCase
def cmd(*args)
output = cmd_output(*args)
status = $?.exitstatus
- puts "\n'brew #{args.join " "}' output: #{output}" if status.nonzero?
- assert_equal 0, status
+ assert_equal 0, status, <<-EOS.undent
+ `brew #{args.join " "}` exited with non-zero status!
+ #{output}
+ EOS
output
end
def cmd_fail(*args)
output = cmd_output(*args)
status = $?.exitstatus
- $stderr.puts "\n'brew #{args.join " "}'" if status.zero?
- refute_equal 0, status
+ refute_equal 0, status, <<-EOS.undent
+ `brew #{args.join " "}` exited with zero status!
+ #{output}
+ EOS
output
end