diff options
| author | Jack Nagel | 2013-01-07 14:06:34 -0600 |
|---|---|---|
| committer | Jack Nagel | 2013-01-07 14:32:14 -0600 |
| commit | 429caf69a9bc3f86e510933d45c8d0cad6db7d10 (patch) | |
| tree | 74326988360354892eb1a21b5f95906ff42e0915 /Library/Homebrew/test | |
| parent | 7473d2b12f8e39385df3e34a8d4e49655a403d3a (diff) | |
| download | brew-429caf69a9bc3f86e510933d45c8d0cad6db7d10.tar.bz2 | |
Remove Array subclassing
Inheriting from Array (and other core types) is problematic:
- It exposes a very wide interface with many methods that are not
really relevant to the subclass.
- It can cause some weird side effects, as many Array operations are
in C and have hardcoded return values; for example, combining two
array subclasses returns a new Array instead of the subclass.
Avoid these problems using delegation and the Enumerable module where
applicable.
Diffstat (limited to 'Library/Homebrew/test')
| -rw-r--r-- | Library/Homebrew/test/test_dependencies.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Library/Homebrew/test/test_dependencies.rb b/Library/Homebrew/test/test_dependencies.rb index 4758aad0a..a09dee7cb 100644 --- a/Library/Homebrew/test/test_dependencies.rb +++ b/Library/Homebrew/test/test_dependencies.rb @@ -30,7 +30,7 @@ class DependencyTests < Test::Unit::TestCase def test_no_duplicate_dependencies @d.add 'foo' @d.add 'foo' => :build - assert_equal 1, @d.deps.length + assert_equal 1, @d.deps.count assert_empty @d.find_dependency('foo').tags end end |